From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EA25B1B2A4
 for <dev@dpdk.org>; Wed, 11 Oct 2017 01:16:29 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 66DE220F30;
 Tue, 10 Oct 2017 19:16:26 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 10 Oct 2017 19:16:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=kcr2ae3LryTZedU
 XI/wXQP3bFZEdFfLpJsPNuNHqtAE=; b=c/sh7a8oRDyRIUKRSjl4DWkCBebpkd0
 9BPO+L0FWS9No2B+zijbBDqqhTpabnXo48RNhTeQlZp+TJOzrs5wG3D0iDpIHMYJ
 2hnDK4gtv+PkEcNApVPNCbKmN604K9u2z0Ql3r0iNHnPz7oLKJIMSmRl6s+kFb+5
 yIpLVVyg2MbE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=kcr2ae3LryTZedUXI/wXQP3bFZEdFfLpJsPNuNHqtAE=; b=P6HuNrNC
 l+qgMnnuXPEE0Ecgo1WOA2D/eCfd37JXP3R79K2atxw95BwJ8ijPSqNbwycapYFs
 izcl67QqACQ/s5CToboM6BpKr5+xD0moSA2HEbuzfiFTpz4SCb3+E9nnn1Hydhzv
 Y1NYXc5UjUqT0pDOYmefCjQ5Ug8NbQcpY3KnrYoGciI7kyHkuJHf7M4c1maRgWVT
 N902B7UIgWQxzt4bWHPtLwVtNTtLE5veDyl+xGf3CRgFhgrJSiq7EYDGTkIqgZMA
 FZNYvtt9yFBV9YN+5t7QlMUGqXXzT3AK6Q9cLmJLeZYNg3X56rXpnVqPWi1u1Htr
 VkchoGUZx5PKQQ==
X-ME-Sender: <xms:ylTdWTf0UuIVKcw1WE2tbwTUtCqPpipWrRGrFADBQmMp5ygQDpGmXA>
X-Sasl-enc: jac/p9qVXHRs0C3vqd3aggJt6C1vIyA+JhdKXr/ux880 1507677386
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1FB43247A9;
 Tue, 10 Oct 2017 19:16:26 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com
Date: Wed, 11 Oct 2017 01:16:25 +0200
Message-ID: <1760785.loeYggim5W@xps>
In-Reply-To: <1507674097-19597-4-git-send-email-nikhil.rao@intel.com>
References: <1507674097-19597-1-git-send-email-nikhil.rao@intel.com>
 <1507674097-19597-4-git-send-email-nikhil.rao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps
	function to SW PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2017 23:16:30 -0000

Hi,

11/10/2017 00:21, Nikhil Rao:
> --- a/lib/librte_eventdev/rte_eventdev_pmd.h
> +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
> @@ -83,6 +83,14 @@ extern "C" {
>         } \
>  } while (0)
>  
> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \
> +               ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \
> +                       (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ))
> +
> +/**< Ethernet Rx adapter cap to return If the packet transfers from
> + * the ethdev to eventdev use a SW service function
> + */

It is a value specific to the SW driver.
I think it should not be defined in librte_eventdev.

Do you mind to move it for RC2?