From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B8B11199B0;
Fri, 12 Jan 2018 15:59:33 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 4A6B420D93;
Fri, 12 Jan 2018 09:59:33 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Fri, 12 Jan 2018 09:59:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=1x25t6Ip3kP5aeNkn54ZKtgy3Y
G/WfSALtGhUk536no=; b=hVBB7vqz134HG2vqRQfBkOFZbhItdl65kz8fnUZKDE
owjKxU/kAZYpWW4vZlthesdP0YnFtjmVGZnk2hc6NrL36AigfuoOTw9z28zQewKj
ZpZmOSAp7sN0oRktyigWeyo16GqWINql23dsRk7ZCVOFzqT7dkGkJiSXY3DdjC6l
A=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1x25t6
Ip3kP5aeNkn54ZKtgy3YG/WfSALtGhUk536no=; b=DVIkAzZ2ZamPlT/Xlma/Vo
LC9uydww17Pl1ICVnyFBSnemq7J7/0UB9qVuupdyGCjiYAmmmV4bf8OpVDNgKf7w
mnhvyt2FI3tp08SqcMmdD31EfpDr3KXwTnFMtt9ZCWtTAqtOTWnnwWb3SIhggxtA
dj2E0x4TJOdHeUUPFn0G0cy1rqjXmv5w0gj/EfcNi4NIpUt74Qg9Vuu2+GXBIzSG
fvDzzj9FQgA35Enle4Av893f/V/V+rpq8LHXpfob0u3PSpvtR/BdUV8kei6RWH6R
YAQd/bM87fwwKM2CMwWjW1n3pIvRpLmjt6PWAkL8EFT4byLYBIu0Mlswy/mhSs0w
==
X-ME-Sender: <xms:Vc1YWo6ivMnT-b5fb44MAbZGBxiyyEr_mmAGPEYb0p0eQ-t7XNSXrg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 0F1AF246CC;
Fri, 12 Jan 2018 09:59:33 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, maryam.tahhan@intel.com, stable@dpdk.org
Date: Fri, 12 Jan 2018 15:59:03 +0100
Message-ID: <1761335.2jqO9XcO2K@xps>
In-Reply-To: <ab9cedc7976ffda3060682a55d15d0cb187ad248.1515765793.git.anatoly.burakov@intel.com>
References: <ab9cedc7976ffda3060682a55d15d0cb187ad248.1515765793.git.anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app: fix proc_info app dependency
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2018 14:59:33 -0000
12/01/2018 15:17, Anatoly Burakov:
> proc_info app is compiled unconditionally on Linux, but it's
> actually dependent on librte_ethdev library, which prevents
> DPDK from building without librte_ethdev library enabled.
>
> Fixes: 22561383ea17 ("app: replace dump_cfg by proc_info")
> Cc: maryam.tahhan@intel.com
> Cc: stable@dpdk.org
nit: please insert a blank line here
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
> -DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info
> +ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),y)
> +DIRS-$(CONFIG_RTE_LIBRTE_ETHER) += proc_info
> +endif
> DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump
What about pdump and testpmd?
I guess a lot of things do not compile without ethdev, isn't it?