From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA087A04F9; Fri, 10 Jan 2020 13:59:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCD851EA0E; Fri, 10 Jan 2020 13:59:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 668B21EA0D for ; Fri, 10 Jan 2020 13:59:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0A3C221C4E; Fri, 10 Jan 2020 07:59:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 10 Jan 2020 07:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=3CNZBYZnQNeqaGCfXgnQp/qJW2nriK2wtXp3wkH4d9U=; b=ryzUcaug8XYw FWtxnFscOzlPxwFmSIwiLYu7TDBN7m2+0qg9KtZgNu5OHo4aO2yLdZicc0ztUib6 hxUmdSksAgDDH8dgBm8dJk4S+tRd8GefpzqcvDBDgeW3Fhc0tor3asgUm2wNhDwl 0GQL9ByzcsFH8vkWNTKAUFJ0uepCWsY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=3CNZBYZnQNeqaGCfXgnQp/qJW2nriK2wtXp3wkH4d 9U=; b=PMYuKmgWVgRw2SLpQ/NW+7EPe0jFoBNQKPbTzWmmopYm7cqANs0tB4JNa cRGMZ77JJv33onEqz8AT0vGOXV/pBMLbW90vnyYv9wcKF9wHk/CyuNBYtVEHHXkh /suIMdhUWTfgErg/+sunBedVXOAmUKYkpoo7X+ANc1yf+8hoVhiMkNK2Ax1VOcZt Do4UVxzudmRCQmK0eCGkk6IMHugFnQE4fv3OpdWc3z9LGGc7u6P/GFfTkJNKB65l xNe5gqmep5ytTR6GTMnznySh3pdMcHs/7sjXwPE9Ei6Ehsv7uU4h6+ihKjusgng1 Tkov30NSMT6kT74XbLvRjVKn6/1Mg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeifedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FCEE8005A; Fri, 10 Jan 2020 07:59:40 -0500 (EST) From: Thomas Monjalon To: "Wang, Haiyue" , Maxime Coquelin Cc: Matan Azrad , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , Andrew Rybchenko Date: Fri, 10 Jan 2020 13:59:36 +0100 Message-ID: <1762954.eGJsNajkDb@xps> In-Reply-To: References: <1577287161-10321-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2020 13:34, Maxime Coquelin: > On 1/10/20 1:31 PM, Wang, Haiyue wrote: > > From: Thomas Monjalon > >> 10/01/2020 10:07, Matan Azrad: > >>> From: Wang, Haiyue > >>>> From: Matan Azrad > >>>>>> delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 > >>>>>> doc/guides/vdpadevs/features/ifcvf.ini > >>>>>> create mode 100644 doc/guides/vdpadevs/ifc.rst delete mode 100644 > >>>>>> drivers/net/ifc/Makefile delete mode 100644 > >>>>>> drivers/net/ifc/base/ifcvf.c delete mode 100644 > >>>>>> drivers/net/ifc/base/ifcvf.h delete mode 100644 > >>>>>> drivers/net/ifc/base/ifcvf_osdep.h > >>>>>> delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode 1006= 44 > >>>>>> drivers/net/ifc/meson.build delete mode 100644 > >>>>>> drivers/net/ifc/rte_pmd_ifc_version.map > >>>>>> create mode 100644 drivers/vdpa/ifc/Makefile create mode 100644 > >>>>>> drivers/vdpa/ifc/base/ifcvf.c create mode 100644 > >>>>>> drivers/vdpa/ifc/base/ifcvf.h create mode 100644 > >>>>>> drivers/vdpa/ifc/base/ifcvf_osdep.h > >>>>>> create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode > >>>>>> 100644 drivers/vdpa/ifc/meson.build create mode 100644 > >>>>>> drivers/vdpa/ifc/rte_pmd_ifc_version.map > >>>>>> > >>>> > >>>> git mv drivers/net/ifc/ drivers/vdpa/ifc ? ;-) > >>> > >>> Yes, and more file move in docs. (you can see like rename in git =F0= =9F=98=8A) > >>> Adjusted also the classes makefiles\measons to remove from net and to= add in vdpa. > >>> Also MAINTAINER file etc... > >> > >> I think the comment from Haiyue was about the files deleted and created > >> in the patch, instead of being moved (renamed). > >=20 > > Yes, I moved one Intel PMD code, then the patch is very small, it is li= ke: > >=20 > > rename drivers/{net/iavf/base =3D> common/iavf}/iavf_common.c (100%) > > rename drivers/{net/iavf/base =3D> common/iavf}/iavf_devids.h (100%) > >=20 > > detail is : https://patchwork.dpdk.org/patch/64384/ >=20 > Nice, and the advantage of doing so is that git would be smarter when > doing backport to stable branch. No, git won't be smarter. As explained below, the format of the diff does not change the internal git representation of the change. Move/Rename is just a nice formatting done by smart detection. > >> As far as I know, this is for 2 reasons: > >> - there is no move in internal git representation > >> - some versions of git-diff does not detect moves properly, > >> but option -M may help