From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
 by dpdk.org (Postfix) with ESMTP id 289492C49
 for <dev@dpdk.org>; Thu,  9 Mar 2017 21:13:17 +0100 (CET)
Received: by mail-wm0-f41.google.com with SMTP id v186so147827120wmd.0
 for <dev@dpdk.org>; Thu, 09 Mar 2017 12:13:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=P3WldeaDj/FgapMd3/eW+WofuCxjcJ/F0OJMVo0gDHo=;
 b=Fq6rFG5hUsIB7ad8HCZ1Kz4N8vD+05OuWKY81cNUacXBf3phYS96iZpIOj3QTlM6l0
 Cj7+9SQfh2BO+iXGGld5h88U7wuGILRwAaaCH5Tc5fLEP+oSAB8rWBsunc9vQCkvfBaY
 CfbNcBZ645AmbYOYoTZG00+qpwqMNGblBiT4aZ6RLkuVbfl5p6pfgK/IAjam69MgE/Sc
 sutBTB3hMLLkRtjEBcF31LKVKeqKN206WfCm1nUBNl6/uN+QxfNJygLnMzwtQWaAWK8o
 +WgFdPFBZIGzRwseJXqLKtuJNgNU+YSk4cIM87c4x48Vc6jSzw17IYexIJmI8lMDrpNc
 YCbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=P3WldeaDj/FgapMd3/eW+WofuCxjcJ/F0OJMVo0gDHo=;
 b=ZNXQFOkS5WoIGGsqyywUz5BCeAzi+tGQQsOsHA13HU90gjJRw4FMNnq2MrJWhoI7m6
 kAicmALMnA6+ZN3M0y/AH4JHlPDYzS75aTIrrR1xKFoillvPuotCPnuRyVzzmzjULy9R
 kzEynmheHMSvQiouYon2KogjpDQ1wjPpyNwZt5p+eLOc1QvQmWBcJxPz4wzFWB+MTnEf
 ASKR9nB6yEqCanHOn1xA2EIMP1EgyG9J4l6rb8gNAnI6DEJbmkziGt28dAkelXDY6DnC
 4S1sZE2rte0QSecTq8hSxrII0zx52ml94nPqSAufw1ViStnBbIoI21WOPkTCTQ07LMez
 L2DQ==
X-Gm-Message-State: AMke39n8gcwBL2FoCA4kjbn5g3KnvvO7uQJeO5qDwh9PN+NXofWdhB/bcIv9P6ShRNZRW5Jz
X-Received: by 10.28.88.2 with SMTP id m2mr31426366wmb.12.1489090396894;
 Thu, 09 Mar 2017 12:13:16 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id y43sm9501527wrd.0.2017.03.09.12.13.16
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Mar 2017 12:13:16 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Markos Chandras <mchandras@suse.de>
Cc: dev@dpdk.org, Nirmoy Das <ndas@suse.de>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, Remy Horton <remy.horton@intel.com>
Date: Thu, 09 Mar 2017 21:13:15 +0100
Message-ID: <1762973.YT1Za91pN5@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20170216161731.4590-1-mchandras@suse.de>
References: <20170216161731.4590-1-mchandras@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] examples: ethtool: Link against
	librte_pmd_ixgbe if necessary
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Mar 2017 20:13:17 -0000

2017-02-16 16:17, Markos Chandras:
> The librte_ethtool library depends on librte_pmd_ixgbe if that
> pmd driver is enabled so we need to link against it when we compile
> the ethtool application. It fixes the following build problem:
> 
> /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld:
> warning: librte_pmd_ixgbe.so.1, needed by /home/abuild/rpmbuild/BUILD/
> dpdk-17.02/examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/
> librte_ethtool.so, not found (try using -rpath or -rpath-link)
> /home/abuild/rpmbuild/BUILD/dpdk-17.02/examples/ethtool/lib/
> x86_64-native-linuxapp-gcc/lib/librte_ethtool.so: undefined reference to
> `rte_pmd_ixgbe_set_vf_rxmode@DPDK_17.02'
> collect2: error: ld returned 1 exit status

We may add this line:
Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function")

> Cc: Nirmoy Das <ndas@suse.de>
> Signed-off-by: Markos Chandras <mchandras@suse.de>
[...]
> --- a/examples/ethtool/ethtool-app/Makefile
> +++ b/examples/ethtool/ethtool-app/Makefile
> +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> +LDLIBS += -lrte_pmd_ixgbe
> +endif

Please, could you confirm we can remove the same LDLIBS line from
examples/ethtool/lib/Makefile ?