From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7A6C82C3F for ; Thu, 14 Dec 2017 08:47:11 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3A03520E40; Thu, 14 Dec 2017 02:47:10 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 14 Dec 2017 02:47:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=3MGyq5mDmTk4UNUH9Ku1kpmHmQ T6oLXVYILt+zIgjfM=; b=oyfGjGoSb+MQ91rxEqjNXD7jyZj0f9Hezk+G3BXFCa XYjNC5cDvd/6b+EEYC9Luqop6whNwI/XB4vmJo2Rg3FvCTULdSua90OYtWmYXQYL bSGyGgC3rylG4SiMgT4KliGHIm8SPPphjmcmCB1/DPIEfXV5NYV6jjNW8uXmkvBL E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3MGyq5 mDmTk4UNUH9Ku1kpmHmQT6oLXVYILt+zIgjfM=; b=JnKBy77GuzAgDhX1vbWgpV f6wZq2Md3DlayhjUo48GDNrm64F56pZXQ5mpSmNGsHCM8czVp5OAPOvA4Lpdh4vu HLvD7hNZS0EGUP+Lp9wuPiKd2j5MpA2gLy5XjTzmCSv/pHOnCE/Ud/wyi/0SJ2gQ 8Wn1MyHddodH6VusHH43MrH52OMMgZoo1d9fBd29MIzK6U+VAsYZJxShpiAjqqWO oHUyxKi8rruEPJlfbr5ZpM5uSCnvpFxumlQ/EXJLw4xv+Cq5DTXxqbj0UQH2oUTE Px9XLK8uqTdPbOkCB1J+DXW9/r4EEUOrBJ7bJMaLRNqwyvwUgBrV9TAo0R2EENbw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E5BE27E404; Thu, 14 Dec 2017 02:47:09 -0500 (EST) From: Thomas Monjalon To: chunmei Liu Cc: dev@dpdk.org, olivier.matz@6wind.com, Wenzhuo Lu , Konstantin Ananyev Date: Thu, 14 Dec 2017 08:47:08 +0100 Message-ID: <1763160.jo7ZIxlbMU@xps> In-Reply-To: <1513208695-65016-1-git-send-email-chunmei.liu@intel.com> References: <1513208695-65016-1-git-send-email-chunmei.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 07:47:11 -0000 14/12/2017 00:44, chunmei Liu: > From: chunmei > > ceph async messenger has some run time error with this dpdk library, > 1) need set rxm->next= null at end of packet since not init it to null > when allocate a buffer other wise rte_mbuf_sanity_check will report error. > 2) when check the size, can't calculate mbuf_data_room_size > because async messenger dpdk will allocate this part later > not at create mempool. > > Signed-off-by: chunmei Liu Hi Chunmei, Several comments about the formatting: I've already notified you that you should Cc Olivier for mbuf changes. You should also Cc Wenzhuo and Konstantin for ixgbe change. Please add them in your next emails. The title should show what is fixed, not the use-case. When sending a new revision of the patch, you should increment the version number and add a changelog below the ---. Please use --in-reply-to when sending a new version, in order to keep track of all versions in the same thread. Your author name and SoB name should be the same (your full name with uppercases): Chunmei Liu For more informations, you should read this: http://dpdk.org/dev#send Thank you