From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 77670C7BC for ; Mon, 22 Jun 2015 22:43:48 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so86766852wib.1 for ; Mon, 22 Jun 2015 13:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PQbiVxpHooNKMmhsXA43vo2ZRLYoVQdwWf8Dvmli7yw=; b=NykLshbRv8arqSZn7m5hwLFFhJwRHgJEJc8l99iX6qa2FZ1pVQ438O1t6oIzC1R8tU jEXYVe3z7afeJB+odY7H1N+5B6vzXw+7MJcP+sAzrJro2M2HuewF/bxKRZJzN3uDmE76 JAlRoJmOGDzvv2z+S/tvJktq73Th7cRM2Wn0JtXd3x/n99hK/RyH04QqjwRBhWS67q5K IrGdlobNfGQcFIf601Vjscj9/Zb6yrHUrx8lDPiNOM2GAlMw1rjPP5yJR/aNVVM03qvz MlXFqMMD7HdxnpKgRzup0hazlk678X9xrNjb8t+EizmC25PHR+/SPjziYimJicdco6Zz ZgNQ== X-Gm-Message-State: ALoCoQlsKo4vbi1Vc15vVaoYr9v4GI1Oae3YuhW7ZwFB2jbyDKZIxsgn6CX7y68sJcav87aTCFwv X-Received: by 10.194.57.211 with SMTP id k19mr55239741wjq.53.1435005828330; Mon, 22 Jun 2015 13:43:48 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id pd7sm32274294wjb.27.2015.06.22.13.43.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 13:43:47 -0700 (PDT) From: Thomas Monjalon To: Cyril Chemparathy Date: Mon, 22 Jun 2015 22:42:46 +0200 Message-ID: <1763224.PSL4DjGVg9@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150622132319.258a5ba3@cchemparathy-ubuntu> References: <1433516110-11468-1-git-send-email-danielx.t.mrzyglod@intel.com> <29909138.qD9kMyzFYN@xps13> <20150622132319.258a5ba3@cchemparathy-ubuntu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: fix RTE_MBUF_METADATA macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 20:43:48 -0000 2015-06-22 13:23, Cyril Chemparathy: > On Mon, 22 Jun 2015 22:16:59 +0200 > Thomas Monjalon wrote: > > Cyril, feel free to fix it if it breaks with Tile arch. > > Why define these locally within rte_port.h? Shouldn't these macros > really be in rte_mbuf.h? No, an application is free to put its metadata elsewhere. The packet framework (port/table/pipeline) did the choice to put some metadata here but there is no need to enforce it for everybody.