From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A0D7A00BE; Mon, 28 Oct 2019 18:10:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4015C1BF8E; Mon, 28 Oct 2019 18:10:45 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 878B41BF7F for ; Mon, 28 Oct 2019 18:10:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3097A21C47; Mon, 28 Oct 2019 13:10:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 13:10:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jN3ssCB8gmGUGoAJkGFw3iB8hJvFetLLh6GhQ2VJbDw=; b=rMAG2BCXU0vz dXNEMwKogN8OHsRY78wPONR4BHXlFiP1D+ubPfnMuw03ZMczpVE1wltIUFFugXBK t657oBMnbvu1MSakByHxBNk2PoA4qGaXfaG8d79V8dYlMjOQO9YVILn0hS2nJOzr /XHGgQ+rLkrHjGp1wu6L4DDXi1YlhrA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jN3ssCB8gmGUGoAJkGFw3iB8hJvFetLLh6GhQ2VJb Dw=; b=fgcPnFV3GRer9Q3mCiT8LL+DvB85K7L/m0kZVUq/WGQmFRoyRc/fQH29n 0D9JXhKAgovLcJc6IWydgkEqLa+SedlOGEyH9/+NaEgUC/UaindzTRN9zgn0/kpC t0gjvFbwfi/D80+TdITJbSa9ZtNz9VGdodsMBDQXOF/G62NvmzP+cEahTbOngWVf VVnDCjASg00pwrcEyuR2WTr+rCb/JfT4So+Lj2KYCW8VZRFhvWRpdmNFuYiA9p9N 4m7yvdrPJl4rtkNunopm/rq7N6nVG9WiI/aB5tV7wDqbQAH7k8ro5J84PceKo0fu L203XqKAsap5rEH78IZelxsUd5ltw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4362FD6005E; Mon, 28 Oct 2019 13:10:41 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: Phanendra Vukkisala , "dev@dpdk.org" , Jerin Jacob Kollanukkaran Date: Mon, 28 Oct 2019 18:10:40 +0100 Message-ID: <1763465.NI4MHNO3Qr@xps> In-Reply-To: <26649674.DGTEfl1OhS@xps> References: <26649674.DGTEfl1OhS@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 18:09, Thomas Monjalon: > 28/10/2019 15:50, Pavan Nikhilesh Bhagavatula: > > >21/09/2019 20:16, pbhagavatula@marvell.com: > > >> From: Pavan Nikhilesh > > >> > > >> Some kernel modules have '-' in their name when populated in > > >> '/sys/bus/pci/drivers/' where as the kernel always populates > > >> '/sys/modules/' with '_'. > > >> Replace '-' in module name with '_' to avoid script complaining > > >> that module not loaded. > > > > > >Sorry it does not look obvious to me. > > >Please, could you describe what is wrong and what is the real cause? > > > > > > > dpdk-devbind.py can also be used to bind devices to kernel modules. > > Some kernel modules are registered with '-' in their name and are populated > > with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_' > > Sorry, still not clear. > What do you mean by "registered"? > > > This confuses the current script making it unable to bind to such modules. The patch > > addresses it by always replacing '-' with '_' when looking in /sys/modules/ > > Yes this sentence is clear (except it is /sys/module/). > Please send a v2 with a clear explanation. Sorry, forgot to insist: You must start the description with what is wrong. You can describe the bug you are experiencing. Thanks