DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
	dev@dpdk.org, "Morrissey, Sean" <sean.morrissey@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v5 0/2] Add config file support for l3fwd
Date: Tue, 22 Feb 2022 10:59:09 +0100	[thread overview]
Message-ID: <1763854.FMhQkTaH9n@thomas> (raw)
In-Reply-To: <DM6PR11MB4491B98A3A980A6CD2B50ACA9A2E9@DM6PR11MB4491.namprd11.prod.outlook.com>

09/02/2022 13:00, Ananyev, Konstantin:
> 
> > > >> Or have a generic library for reading LPM entries.  L3fwd is supposed
> > > >> to be as small as possible (it no longer is), and the real work should
> > > >> be done by libraries to make it easier to build other applications.
> > > >
> > > > I never heard users ask about such thing,
> > > > but if there is a demand for that, then I suppose it could be considered.
> > > > CC-ing LPM/FIB maintainers to comment.
> > > > Though I believe it should be a subject of separate patch and discussion
> > > > (I think many questions will arise - what format should be, how to support
> > > > different types of user-data, to make it generic enough, etc.).
> > >
> > > Agree, it is very application specific, so it could be really difficult
> > > to make it generic.
> > 
> > But several other also have LPM tables, so why not have common code for other applications.
> > 
> > examples/l3fwd-power/main.c
> > examples/ipsec-secgw/rt.c
> > examples/ip_fragmentation/main.c
> > examples/l3fwd/l3fwd_lpm.c
> > examples/ip_reassembly/main.c
> 
> Ah yes, that's good point.
> All these examples (except ipsec-secgw) started as l3fwd clones,
> so all of them have hard-coded LPM (and EM) tables too.
> Yes it would be good thing to address that problem too,
> and have some common code (and common routes file format) for all of them.
> I don't know is that a good idea to introduce parse file function in LPM/FIB library
> itself, might be better to  have something like examples/common/lpm_parse*.
> Anyway, this is an extra effort, and I think no-one has time for it in 22.03 timeframe.
> My suggestion would be for 22.03 go ahead with current l3fwd patches,
> then later we can consider to make it common and update other examples.

I don't think this patch is urgent.
I suggest taking time to have common code for all examples
and target a merge in DPDK 22.07.



  parent reply	other threads:[~2022-02-22  9:59 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 15:01 [PATCH v1 " Sean Morrissey
2021-12-16 15:01 ` [PATCH v1 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2021-12-16 15:01 ` [PATCH v1 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2021-12-20 11:08 ` [PATCH v2 0/2] Add config file support for l3fwd Sean Morrissey
2021-12-20 11:08   ` [PATCH v2 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2021-12-20 15:42     ` Ananyev, Konstantin
2021-12-20 11:08   ` [PATCH v2 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2021-12-20 15:53     ` Ananyev, Konstantin
2021-12-21 12:30   ` [PATCH v3 0/2] Add config file support for l3fwd Sean Morrissey
2021-12-21 12:30     ` [PATCH v3 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2021-12-21 12:30     ` [PATCH v3 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2022-01-10 14:00       ` Ananyev, Konstantin
2022-01-26 12:44     ` [PATCH v4 0/2] Add config file support for l3fwd Sean Morrissey
2022-01-26 12:44       ` [PATCH v4 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2022-01-26 12:44       ` [PATCH v4 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2022-02-04 19:59       ` [PATCH v5 0/2] Add config file support for l3fwd Sean Morrissey
2022-02-04 19:59         ` [PATCH v5 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2022-02-08  2:21           ` Han, YingyaX
2022-02-04 19:59         ` [PATCH v5 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2022-02-04 22:26         ` [PATCH v5 0/2] Add config file support for l3fwd Stephen Hemminger
2022-02-06 15:16           ` Ananyev, Konstantin
2022-02-08  3:04             ` Stephen Hemminger
2022-02-08 10:44               ` Ananyev, Konstantin
2022-02-08 16:15                 ` Medvedkin, Vladimir
2022-02-08 17:49                   ` Stephen Hemminger
2022-02-08 18:10                     ` Bruce Richardson
2022-02-09 12:00                     ` Ananyev, Konstantin
2022-02-09 13:54                       ` Bruce Richardson
2022-02-09 16:00                         ` Medvedkin, Vladimir
2022-02-22  9:59                       ` Thomas Monjalon [this message]
2022-02-22 10:39                         ` Ananyev, Konstantin
2022-02-22 13:46                           ` Thomas Monjalon
2022-02-22 15:13                             ` Ananyev, Konstantin
2022-02-22 16:48                               ` Thomas Monjalon
2022-02-24 11:06                                 ` Ananyev, Konstantin
2022-02-24 13:46                                   ` Thomas Monjalon
2022-02-24 13:58                                     ` Bruce Richardson
2022-02-25 10:36                                       ` Ananyev, Konstantin
2022-02-25 10:40                                         ` Bruce Richardson
2022-02-25 12:21                                           ` Ananyev, Konstantin
2022-02-25 12:50                                           ` Morten Brørup
2022-02-25  5:18                                     ` Honnappa Nagarahalli
2022-03-01 14:49         ` [PATCH v6 " Sean Morrissey
2022-03-01 14:49           ` [PATCH v6 1/2] examples/l3fwd: add config file support for LPM/FIB Sean Morrissey
2022-03-01 14:49           ` [PATCH v6 2/2] examples/l3fwd: add config file support for EM Sean Morrissey
2022-03-08  8:57           ` [PATCH v6 0/2] Add config file support for l3fwd Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1763854.FMhQkTaH9n@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=sean.morrissey@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).