From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BA3174D3A
 for <dev@dpdk.org>; Thu,  1 Nov 2018 15:51:01 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 3C8DF22302;
 Thu,  1 Nov 2018 10:51:01 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 01 Nov 2018 10:51:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=seu1fL9ZPhRcgod1USOlZLYYigxy/M7ciEoQeE82G0E=; b=K6nIBMW7JnCG
 fQCTzhj58PBjjcw8q4ZOKYeuMw+6Qr+VHTKry0F1Ycb9MUWPOdUltEJtpuerx9ew
 CvA2iekIlPShLi05HmNIvPW9jQ4UXs3laHCo6MmfqKZwsVPzQeeO1WHvWNSLWJ35
 XVakHQdvArgn6l4v+hP+XVogj0lOKDM=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=seu1fL9ZPhRcgod1USOlZLYYigxy/M7ciEoQeE82G
 0E=; b=uPfBCTknfynZr21z390UFCqK6aFg3k+bRjQz1ZcaBDs/9McJlKYoyUo5C
 HHw0gsomrASHWyHtEadI+GyiJMkBzoEWKKG+v4Jytol8LqLJ1MRm6ZwyyTt0xN61
 DXXOtyhWFR9uLvjcaE2Mb4XcgiTyBMNMGsRHKrT/yMxp3APRMWW+StccqrAopnhT
 LGluvFnVMkmP8Ns7TsD2Way9SOxS9+ndORnfXBb4ehwJcgCe4lD3PJoBZn0/IILh
 KWHghIMv6ewjdAkwF/KLwgpBNOdIEoJp01U3yanx9b5R0H2+LbF8jkuM/BaJHgjT
 PrvBVsWb4F1Sa3K1eO/dPtA3R+rtQ==
X-ME-Sender: <xms:1BLbW_TyEtTcJI-aeuukgOIFrhlHUtnqwrY6Isnzt6CbDXDG8ejVFg>
X-ME-Proxy: <xmx:1BLbW28DHEFKeaq9U8wib7e89AeJpUAHLbXUdfx2hpdfFV4cxrYH7A>
 <xmx:1BLbW5DsxYUSCX7709fcUXAWrIdBxWUTirULcNSxpTsxYpthTpbRGw>
 <xmx:1BLbW7lcQxVktowyvVu5MicpdB1I25_kK3SHiG5n2w4g-R3k8-lvLQ>
 <xmx:1BLbW1uW0fErdStAMuj6qeAWseB_SGrbbTU8bTJUnY7V6lrmBC7rkw>
 <xmx:1BLbW9IkH-oNiXvHYyivqH2nD8ESFzjYvI6i2I0-L4hDxRXEAX9kOQ>
 <xmx:1RLbW_23DhVWdan0huowiJux9h6El0ozgkISY08LX6ovDneWzaYU6Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E04E8E467A;
 Thu,  1 Nov 2018 10:50:59 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org
Date: Thu, 01 Nov 2018 15:50:59 +0100
Message-ID: <1764123.29vNcfR2yM@xps>
In-Reply-To: <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
References: <20181031172931.11894-1-alejandro.lucero@netronome.com>
 <20181031172931.11894-3-alejandro.lucero@netronome.com>
 <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/7] mem: use proper prefix
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2018 14:51:02 -0000

01/11/2018 11:08, Burakov, Anatoly:
> On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> > Current name rte_eal_check_dma_mask does not follow the naming
> > used in the rest of the file.
> > 
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> 
> I don't think this belongs in the _mem_ namespace. It is usually used 
> for things to do with memory, while the DMA mask IMO sits firmly in the 
> domain of EAL, specifically bus subsystem.

It is a memory allocation check, isn't it?

I think rte_mem_ prefix is more meaningful.
Anyway, we should avoid rte_eal which is too vague.
For device management, we use rte_bus, rte_dev, etc.

> However, i don't have strong feelings one way or the other, so if you do 
> decide to go forward with this naming...