From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8E1262BD1 for ; Fri, 16 Jun 2017 16:09:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 359F22089C; Fri, 16 Jun 2017 10:09:06 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 16 Jun 2017 10:09:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=WxcOSwqBtzoXgAd xAZW9LWhOrMJQcsEeP5KooCuyIDI=; b=D/QA5ugJLh47U3Z5raTzgz8Sr22/3cL xG7r8W4CdaonnuBwQH5fWtpelCZRwfhm0kBCBaVR4StMAs9N9881IRRpeL9daMdk 9TwWLsv2SCvVljcuhTaihr6eQ/dPB7UR6my2g9/5qx7TUKotDvW7fDRCW/lTw/zx bbFDp+yWmtVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=WxcOSwqBtzoXgAdxAZW9LWhOrMJQcsEeP5KooCuyIDI=; b=OiXwTQ6T iCrknK5WJKgNJSo0k/xpSH6dHi0GlystyrqHqwEAXFgsudMwtBLDFl6tx9fhRqqf VwGSeLl7iXdvAimBYcsTyvp7THhtdvRBmeZK86uPT4CZqDKFfC70lTc8WM6s507b vpPwtpzb5ksc1Lfxhqmg0/yKxnA9gSVw0vI22PlwGXfFaNmyr26KdidkVsxl7BfQ gc9NkkEum9qvfJ928totoow8vLiTZa0eAFY7ROYaapJJqQxVdxlXbaZDbxUbUrec CYCxW7kJQeYYUBh1ERyKHfMKqui2WFMi/jyioivlEoKeSXhCnUbEVcPTweaGd5+Z UOxXw+d9LUvtpg== X-ME-Sender: X-Sasl-enc: Hupjmko4vOZ7FyW6lCfwT9tLQYB46LHQsHXD6fGwpXCs 1497622145 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4FEE7E850; Fri, 16 Jun 2017 10:09:05 -0400 (EDT) From: Thomas Monjalon To: "Lu, Wenzhuo" , "Nicolau, Radu" Cc: dev@dpdk.org Date: Fri, 16 Jun 2017 16:09:04 +0200 Message-ID: <1764991.rUGqORsVcK@xps> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CF493@shsmsx102.ccr.corp.intel.com> References: <20170615095446.2187-1-thomas@monjalon.net> <6A0DE07E22DDAD4C9103DF62FEBC09093B5CF493@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2017 14:09:06 -0000 16/06/2017 03:29, Lu, Wenzhuo: > From: Nicolau, Radu > > > > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling > > IXGBE? > > Although the scenario doesn't make sense, I think it's better to add more check to avoid the users making any mistake. Applied