From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C8942A0524;
	Tue, 13 Apr 2021 18:44:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E607616119D;
	Tue, 13 Apr 2021 18:44:37 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 3160A16111F
 for <dev@dpdk.org>; Tue, 13 Apr 2021 18:44:35 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 8EA3F5C0178;
 Tue, 13 Apr 2021 12:44:34 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Tue, 13 Apr 2021 12:44:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 MuF24MX/CmvVboF+hsd6kDqlZjkBzeAwIDHiJWmAQhc=; b=Dg3ReG4M4dK2Zu7l
 bIIsn2BKYr1Fp/VdDSrGI/WwU07u2LQk16sKbn8M5IMkBVt4JBmpeWa0adMS/BBz
 4ehFNZz1O6LKdfoi4ePb9mAecDRE3g8M5/b/9sQa3+H6Q9vrJvz2H6h/1jLZ9283
 IqDEzKDO5wCW/GZ7BBKnSwm0kXUrD9V0a/AcLZAkWkQQlrdJnwg6sG9f61SqSAJg
 RKlnwhcn7bvIaBeGzUPhsLIbvrdQCpj9gZ/Y/mvSj7KReFBB4LY8CNdvdJBGFCP5
 7djGzrYBJJ2D4iTZya84VdHfso1ACTHlXq0n8ql7vFkWXdy+rZrAHohf+sx5L7zL
 bZ8j3A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=MuF24MX/CmvVboF+hsd6kDqlZjkBzeAwIDHiJWmAQ
 hc=; b=g2CzeOFpmPjd62umFsV4SJMvuOdtFN5MsFp/59nswaB2LN4SUJGn+b3ot
 1sDeNfkROPpb/rvJu69YzM1OG5KrbJ1vgBvBYSC0aWqNd+13Mn8JWXEJPheLOmxU
 bjWM2nYvmk9aUjvTPIFTjxfLDsxApUcs5uPOIcz/I/clNnwQy76btG8f2SxlUOfq
 qQLYfEak2hJwN/DqfG7SgNJs2bW+rm0ffFvmhlmerXlxeIf461sKP1+ttil/MTqY
 hwLWqgVs540GaHBf0mIiGyU5+v1zmU2vtNZE7uOUnC3pP0e8oAwZ8L+HANid0Bkh
 EYcHRzJkF0Yl634leoU2MoCvl7uOQ==
X-ME-Sender: <xms:ccp1YEZvE_OlnHR1cbkVHoG0gCvgwZJ8DiSmFQJI1NogrG8PNX2pDw>
 <xme:ccp1YJ9SsatHEVl8v2Y6_etiiN5jGLrvQySmEJKjwRLZftakWySURJSq7lSukgC5I
 Ycp0J-A89UCPefYBA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledguddtgecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
 ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
 fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
 lhhonhdrnhgvth
X-ME-Proxy: <xmx:ccp1YLgVb1BgG8xycdIMClWfbImwCJMbNBpvSP3nDrt7HDVvX4MvbQ>
 <xmx:ccp1YBfFsE9qmUjDm8PbGa6GTpUNgNPk1umVRPTeu_Cy0TkMjkRvjA>
 <xmx:ccp1YKriILG64k9SMAkM9uQy1mkOcJatLLW9Q-fY4Lt99YqY4CwHWw>
 <xmx:csp1YKCfbwqe6s_OeUg1OYL3ArO6Uz7Q1xffKjMdEMo34a2lR2DhsA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 30ECD24005A;
 Tue, 13 Apr 2021 12:44:33 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Kinsella, Ray" <mdr@ashroe.eu>
Cc: dev@dpdk.org, jerinj@marvell.com,
 David Marchand <david.marchand@redhat.com>,
 Neil Horman <nhorman@tuxdriver.com>,
 Timothy McDaniel <timothy.mcdaniel@intel.com>
Date: Tue, 13 Apr 2021 18:44:32 +0200
Message-ID: <1766003.i8BfvDrVoT@thomas>
In-Reply-To: <e8a2750f-afa8-f35e-8f2b-aef2023c0551@ashroe.eu>
References: <CAJFAV8x0-8pWr4mj86n=wzmX5jxS9C5D-jqEW+d8z3vcc+AABA@mail.gmail.com>
 <20210413084525.3057669-1-thomas@monjalon.net>
 <e8a2750f-afa8-f35e-8f2b-aef2023c0551@ashroe.eu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI
 check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/04/2021 18:09, Kinsella, Ray:
> On 13/04/2021 09:45, Thomas Monjalon wrote:
> > The eventdev driver DLB was removed in DPDK 21.05,
> > breaking the ABI check.
> > The exception was agreed so we just need to skip this check.
> > 
> > Note: complete removal of a driver cannot be ignored
> > in devtools/libabigail.abignore, so the script must be patched.
> > 
> > Fixes: 698fa829415d ("event/dlb: remove driver")
> > 
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > This should have been done as part of removing the driver.
> > The CI is currently broken, so it should be merged today.
> > ---
> >  devtools/check-abi.sh | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> > index 9835e346da..ca523eb94c 100755
> > --- a/devtools/check-abi.sh
> > +++ b/devtools/check-abi.sh
> > @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
> >  		echo "Skipped glue library $name."
> >  		continue
> >  	fi
> > +	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> > +		echo "Skipped removed driver $name."
> > +		continue
> > +	fi
> 
> So this is brute force fix - we can anticipate this problem happening again.
> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?

Yes indeed we could have a file for this.
Maybe we could have a dedicated section [suppress_lib]
in the existing file if libabigail is OK with unknown sections?