From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83C90A0350; Thu, 25 Jun 2020 21:29:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E612E07; Thu, 25 Jun 2020 21:29:19 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E22CB3B5 for ; Thu, 25 Jun 2020 21:29:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1790D5C0035; Thu, 25 Jun 2020 15:29:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 25 Jun 2020 15:29:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 7f9l95MQi/GfRKKXxxSB3YCSny+lzUMz6WhehDOHcvA=; b=rqU0sdqQrnKDkwYi D5UMWkrVmz4cJnYAEmtS9Q91dv0JgANnN18k4n3ZS4EPvLga0AXp9SN2JO83jA5Z FU2gC/DiPsuEqDnJSGFH3aDXlESmS/83hO7rTeKstGCjtFVwlUsEihqPNSIgGY90 6BIRVc5e5NNTXGULDbNkqeJCI/NIJVyqubyE0BGuTr0kozdR1cBObFD3Q1FY5y0N XvebEv8a/rKx3cAjr1jnAYLmRCMUBVohAoI9QxcBYzAYzfhcvGwdwAdKq8dJO7Kz F0klisqr1hM9LF/cybBboqvXief0F9cCrhpq4uWNANvNdBa3SG+p93oSx7uqvvQA JQCX/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=7f9l95MQi/GfRKKXxxSB3YCSny+lzUMz6WhehDOHc vA=; b=CVdoucHzao7UbBlF8/HIZ2eYtsRxSKBbTgrGQk+nvEqXNybrJFDH+jPlP 3hXHLO0gwTPNxylp3CX/uPqZnm39li6EybVc9qlMUy3I9FdrkAoTYSeu1g84Pt0b 2c98V24/Y92DC89nfL7C4RNFEGMSwvq1FTUJ5Y/eYmIB9Ha/U6KOPVe0MJZlndiq 7OMo/V/0D5ZesB5pEK3AjmDBu9c9dfbi0xu+lFTRT7U6RO3W3Uw8P7sncJ0/jQId JckWtWwPqwKfPoFCHkZaBXzY5R8K/40JWDfBvdYlBEwgRiXbm3uFsDw57Gbj16FT uetH+IbRmNK1Mlb0V1mJJ/DGNY9WA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekledgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8487D3067808; Thu, 25 Jun 2020 15:29:15 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Jiawei Wang , Ori Kam , Slava Ovsiienko , Matan Azrad , dpdk-dev , Raslan Darawsheh , ian.stokes@intel.com, fbl@redhat.com Date: Thu, 25 Jun 2020 21:29:13 +0200 Message-ID: <17660414.AQMWyGVKyv@thomas> In-Reply-To: References: <1593102379-400132-1-git-send-email-jiaweiw@mellanox.com> <1593102379-400132-2-git-send-email-jiaweiw@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/06/2020 19:55, Jerin Jacob: > On Thu, Jun 25, 2020 at 10:20 PM Jiawei Wang wrote: > > > > When using full offload, all traffic will be handled by the HW, and > > directed to the requested vf or wire, the control application loses > > visibility on the traffic. > > So there's a need for an action that will enable the control application > > some visibility. > > > > The solution is introduced a new action that will sample the incoming > > traffic and send a duplicated traffic in some predefined ratio to the > > application, while the original packet will continue to the target > > destination. > > > > The packets sampled equals is '1/ratio', if the ratio value be set to 1 > > , means that the packets would be completely mirrored. The sample packet > > can be assigned with different set of actions from the original packet. > > > > In order to support the sample packet in rte_flow, new rte_flow action > > definition RTE_FLOW_ACTION_TYPE_SAMPLE and structure rte_flow_action_sample > > Isn't mirroring the packet? How about, RTE_FLOW_ACTION_TYPE_MIRROR > I am not able to understand, Why it is called sample. Sampling is a partial mirroring. Full mirroring is sampling 100% packets (ratio = 1). That's why only one action is enough.