[dpdk-dev] [PATCH 0/2] net/sfc: minor fixes for 17.11

[dpdk-dev] [PATCH 0/2] net/sfc: minor fixes for 17.11

[Andrew Rybchenko]

Please, if possible, include these minor fixes in 17.11 release.

Andrew Rybchenko (2):
  net/sfc: avoid Rx queue setup failure if thresholds are set
  net/sfc: avoid Tx queue setup failure if thresholds are set

 drivers/net/sfc/sfc_rx.c | 3 +--
 drivers/net/sfc/sfc_tx.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/2] net/sfc: avoid Rx queue setup failure if thresholds are set

[Andrew Rybchenko]

Rx queue prefetch, host and writeback thresholds are used for
performance fine-tuning and not applicable to Solarflare NICs.
It is safe to just log warning and do not fail Rx queue setup
to be more friendly to DPDK applications which hardcode it.

Fixes: ce35b05c635e ("net/sfc: implement Rx queue setup release operations")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_rx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
index 2ae095b..7816393 100644
--- a/drivers/net/sfc/sfc_rx.c
+++ b/drivers/net/sfc/sfc_rx.c
@@ -780,9 +780,8 @@ sfc_rx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_rx_desc,
 	if (rx_conf->rx_thresh.pthresh != 0 ||
 	    rx_conf->rx_thresh.hthresh != 0 ||
 	    rx_conf->rx_thresh.wthresh != 0) {
-		sfc_err(sa,
+		sfc_warn(sa,
 			"RxQ prefetch/host/writeback thresholds are not supported");
-		rc = EINVAL;
 	}
 
 	if (rx_conf->rx_free_thresh > rx_free_thresh_max) {
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] net/sfc: avoid Tx queue setup failure if thresholds are set

[Andrew Rybchenko]

Tx queue prefetch, host and writeback thresholds are used for
performance fine-tuning and not applicable to Solarflare NICs.
It is safe to just log warning and do not fail Tx queue setup
to be more friendly to DPDK applications which hardcode it.

Fixes: b1b7ad933b39 ("net/sfc: set up and release Tx queues")
Cc: stable@dpdk.org

Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_tx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c
index 127d59e..d1320f4 100644
--- a/drivers/net/sfc/sfc_tx.c
+++ b/drivers/net/sfc/sfc_tx.c
@@ -79,9 +79,8 @@ sfc_tx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_tx_desc,
 	if (tx_conf->tx_thresh.pthresh != 0 ||
 	    tx_conf->tx_thresh.hthresh != 0 ||
 	    tx_conf->tx_thresh.wthresh != 0) {
-		sfc_err(sa,
+		sfc_warn(sa,
 			"prefetch/host/writeback thresholds are not supported");
-		rc = EINVAL;
 	}
 
 	if (((flags & ETH_TXQ_FLAGS_NOMULTSEGS) == 0) &&
-- 
2.7.4

Re: [dpdk-dev] [PATCH 0/2] net/sfc: minor fixes for 17.11

[Thomas Monjalon]

14/11/2017 12:32, Andrew Rybchenko:
> Please, if possible, include these minor fixes in 17.11 release.
> 
> Andrew Rybchenko (2):
>   net/sfc: avoid Rx queue setup failure if thresholds are set
>   net/sfc: avoid Tx queue setup failure if thresholds are set

Applied, thanks