Re: [dpdk-dev] [PATCH 1/4] app/testpmd: add queue deferred start switch

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 9/3/18 7:56 PM, Ferruh Yigit wrote:
> On 8/29/2018 8:16 AM, Andrew Rybchenko wrote:
>> From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
>>
>> Signed-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>   app/test-pmd/cmdline.c                 | 91 ++++++++++++++++++++++++++
>>   doc/guides/rel_notes/release_18_11.rst |  6 ++
>>   2 files changed, 97 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 589121d69..f47ec99f1 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -883,6 +883,10 @@ static void cmd_help_long_parsed(void *parsed_result,
>>   			"    Start/stop a rx/tx queue of port X. Only take effect"
>>   			" when port X is started\n\n"
>>   
>> +			"port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\n"
>> +			"    Switch on/off a deferred start of port X rx/tx queue. Only"
>> +			" take effect when port X is stopped.\n\n"
> Overall looks good to me.
>
> But testpmd doc needs to be updated to add new command.
> doc/guides/testpmd_app_ug/testpmd_funcs.rst

Will fix in v2

> Also is there a way to see the current deferred_start status of a port, either
> with a specific command or as part of other command like "show port info"?
> If not does it make sense to have a way to see it?

The following command does it:
show rxq|txq info <port_id> <queue_id>

Thanks,
Andrew.