From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 78F8811C5 for ; Tue, 16 Jun 2015 12:23:17 +0200 (CEST) Received: by wifx6 with SMTP id x6so14695628wif.0 for ; Tue, 16 Jun 2015 03:23:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=IXM+lcsPjY+GqOMbVjNy3gGkroXnp2z0/+PUE7/7Bbc=; b=j+bn0DXGhtcmWgrQutOBC+SWtM5n4wWZCGHndqCWvO8YUAzmPVJvSLjROsjSJU+Ogh XvJhY9mgjA3gY9o3r3aRxGRp/kzAUdOn2xbhdRIzWqjiOhP0oCs8ps4nOWpAfqJBYcGd 65syNsPOrko+AdHSzzeNTZH5Qu2HxOoO1U7M2JqQat1ninBA2bC/8bU4xx4rVinc2DEQ 94yE7EUj/g2OpTOrTTg457Mx0yT0DM5eX3VHbBGzFrSPFM7WrQgFN+We6wETWzduek97 zRNYYB4MBJe7NFhwkTKsL77Q4zsc50Qw7g19bBjDPp4TYUMYuzL5Jy4jwE1SOW4KB4sf /weQ== X-Gm-Message-State: ALoCoQkDpLbYRtCGIS//9FEHwRPCzkHbCyP5TtdIATVlcH3lMk2zK3ZgKRpijY3HDLpd9HBpq8Wu X-Received: by 10.180.87.201 with SMTP id ba9mr41359685wib.73.1434450197202; Tue, 16 Jun 2015 03:23:17 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bh7sm945833wjb.8.2015.06.16.03.23.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 03:23:15 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Date: Tue, 16 Jun 2015 12:22:17 +0200 Message-ID: <1768969.VfWjhKItIR@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150612103736.GA10552@bricha3-MOBL3> References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com> <20150612103736.GA10552@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 00/10] update jhash function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 10:23:17 -0000 2015-06-12 11:37, Bruce Richardson: > On Wed, Jun 10, 2015 at 04:25:17PM +0100, Pablo de Lara wrote: > > Jenkins hash function was developed originally in 1996, > > and was integrated in first versions of DPDK. > > The function has been improved in 2006, > > achieving up to 35% better performance, compared to the original one. > > > > This patchset updates the current jhash in DPDK, > > including two new functions that generate two hashes from a single key. > > > > It also separates the existing hash function performance tests to > > another file, to make it quicker to run, and add new unit tests. > > > > changes in v6: > > - Use RTE_DIM macro, so it saves lines of code > > - Correct mistaken performance improvement > > - Add deprecated attribute, instead of printing a message calling it > > - Add note stating the changes in release notes > > > > changes in v5: > > - Add functional tests (mainly to test that all functions > > return the expected hash values) > > - Modify range of key sizes to test > > - Change order of output for perf tests, so it is clearer > > to compare different hash functions for same key size/initial value > > - Add new initial value to test in the hash functions > > - Fix some errors caught by checkpatch > > > > changes in v4: > > - Simplify key alignment checks > > - Include missing x86 arch check > > > > changes in v3: > > > > - Update rte_jhash_1word, rte_jhash_2words and rte_jhash_3words > > functions > > > > changes in v2: > > > > - Split single commit in three commits, one that updates the existing functions > > and another that adds two new functions and use one of those functions > > as a base to be called by the other ones. > > - Remove some unnecessary ifdefs in the code. > > - Add new macros to help on the reutilization of constants > > - Separate hash function performance tests to another file > > and improve cycle measurements. > > - Rename existing function rte_jhash2 to rte_jhash_32b > > (something more meaninful) and mark rte_jhash2 as > > deprecated > > > Thanks for the all the work, and rework, Pablo. > > Series Acked-by: Bruce Richardson Applied, thanks Some doxygen typos has been fixed on the fly.