From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 150F7325B for ; Mon, 4 Dec 2017 23:31:23 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2017 14:31:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,361,1508828400"; d="scan'208";a="9036995" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.178]) ([10.241.225.178]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2017 14:31:22 -0800 To: Shahaf Shuler , jingjing.wu@intel.com Cc: dev@dpdk.org References: <20171123120804.143897-1-shahafs@mellanox.com> <20171123120804.143897-3-shahafs@mellanox.com> From: Ferruh Yigit Message-ID: <176b53a6-e211-a7e4-c323-df8138505f3e@intel.com> Date: Mon, 4 Dec 2017 14:31:21 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171123120804.143897-3-shahafs@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 22:31:24 -0000 On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > Since testpmd is now using the new Ethdev offloads API there is no > need for the txqflags configuration. txqflag command-line option (--txqflags=0xXXXXXXXX) and command (port config all txqflags value) are way to dynamically provide Tx offload configuration to testpmd. Why you are removing them without providing equivalent feature with new offload APIs? Patch 3/4 & 4/5 adds new command-line options to enable some of recently introduced Tx offloads in testpmd, why not add a generic way to update all Tx offloads instead of those two specific offloads? Also this patch removing ability to display current Tx offload configuration.... > > Signed-off-by: Shahaf Shuler > Acked-by: Nelio Laranjeiro <...>