Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thomas Monjalon <thomas@monjalon.net>]

29/06/2021 13:35, Dumitrescu, Cristian:
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 21/06/2021 17:54, Thierry Herbelot:
> > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > > >>>>> Check Bucket key for all possible indices.
> > > > >>>>>
> > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > > >>>>> Cc: stable@dpdk.org
> > > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>>
> > > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >>> [...]
> > > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[2])
> > > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[3])
> > > > >>>>
> > > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>
> > > > >>>> Thierry, thanks again, you could have actually added my ack from V1
> > > :)
> > > > >>>
> > > > >>> The root cause looks to be a typo indeed,
> > > > >>> but the impact or the scope of the issue
> > > > >>> should stated in few words in the title please.
> > > > >>> No need to send a v3, please suggest a title and I will apply.
> > > > >>
> > > > >> table: check a bucket is empty for all bucket keys
> > > > >>
> > > > >> 	Thierry
> > > > >>
> > > > >
> > > > > Hi Thierry,
> > > > >
> > > > > I think Thomas is asking for you to send a new version of this patch with
> > > the title updated. Is this OK with you?
> > >
> > > No need to send a v3.
> > 
> > OK, so you're going to fix the title while applying? Thanks, Thomas.
> 
> Hi Thomas,
> 
> I see this fix is not yet applied, is there any action required?

The proposed title is not fantastic. Last one is:
table: all keys must be checked to declare that a bucket is empty

I just need a title showing what is fixed.
What is the impact of the bug in bkt_is_empty()?