From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA9D24415D; Wed, 5 Jun 2024 14:14:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9F8640DDD; Wed, 5 Jun 2024 14:14:56 +0200 (CEST) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id 3C82B40289 for ; Wed, 5 Jun 2024 14:14:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A96BA11401C9; Wed, 5 Jun 2024 08:14:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 05 Jun 2024 08:14:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717589694; x=1717676094; bh=lHBVkce2uois/QnCbqDtbeve+4m/Pw1nzQ+3ylpWaLY=; b= BGj7ZUeKXL8ey3+/pLSm1wqPRcXYuZ1rU/6YKOoa1G9aeK5aptRKmh6w/q4vGyQJ 6NI2IyzrE+en9b+6WTPt4aDHZC+lXJKihVmpcs45FzVrdbX8Z0ak0Lt4HVW5Up0H 4tWVSbNfB75YzDlBvavQJza1QMWniMHfRXCahZNhgwpAO6AhD8MroxJVg2IjjZHz 0IAKObPFzc8yaX6FtFbq/mcUXgNi54uUIK++LkbNDBoiy0GvQEH+B+2ku+jnil7m 8TKT93IGnHNtQvOMKbsSDT6sQqLjMSIl2yIRsH/oGpQQMIaWxFScjQJPAOwDgYOP d/tCf9ziCWmj7KMNCaYvVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717589694; x= 1717676094; bh=lHBVkce2uois/QnCbqDtbeve+4m/Pw1nzQ+3ylpWaLY=; b=H LT7RNDJyI+dk4q/32aB40uGTEv0Fm+D9bLguik84FBnnLyjLyjZ1MywC16Dqxv5V ThgWxBWfHy0EIB5KSvx0cylQasxXqhlHx3BXDjosTqCoAlLSTm7+u+cXJIZYgQL2 5T4b0D8msm4RIWgKQ9ciTeYIVOh5qdoKH8zM7/paxYqFmuBbwLHOqXn3pYSFUfeG aCudrSC2IdQTg6YerLvqvR3BwjMzsPxZhgdK/8JlAor1Ig++msbvaIUC0QlF+pkH HhGcN2c/KrSFfn5v0DkfpQYNLGxIOOErUI058q2UUZLkO6q2alI5AdTXs+e7Q/eL sAtdnorXkTn5r6DGQGpGQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeliedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jun 2024 08:14:53 -0400 (EDT) From: Thomas Monjalon To: rongwei liu Cc: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou Subject: Re: [PATCH v6 2/4] net: add new union into VXLAN header Date: Wed, 05 Jun 2024 14:14:51 +0200 Message-ID: <1771398.K4a6FZZPjd@thomas> In-Reply-To: References: <6203165.YiXZdWvhHV@thomas> <2818222.B0Pyx7erxp@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/06/2024 13:28, rongwei liu: > From: Thomas Monjalon > > 05/06/2024 12:21, Rongwei Liu: > > > Add "uint8_t last_rsvd" as union with origin rsvd1. > > > > You should explain why: for matching what we have in testpmd. > > I think it should be squashed with the next patch. > > Sure. Let' squash them, still with "ethdev" prefix? Yes, the main change is adding new field item in ethdev. > The explanation should in the commit log not in the header file. What do you think? Yes, explanation in the commit log.