From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8226AA00BE; Mon, 28 Oct 2019 18:16:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7572F1BF8F; Mon, 28 Oct 2019 18:16:26 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id EDF231BF8E for ; Mon, 28 Oct 2019 18:16:24 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 488405C7B; Mon, 28 Oct 2019 13:16:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 13:16:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=wCvnfXqOkW7mOh797h9Xevz2/SPyk1DScs+ep10jdc0=; b=ihqPuSjdKznh BwMFaaiNukWNRNWg2P/023TNdtSVl1MU/w0ZlCm1b2KdkAlYCWanJpOcfesdjk1R IuA2t7iz9J+j3+QwylZ0cSVQSAM7p6MJ9B0wZyJu2z4s6atehs21gxjbjdopKp8T 83QZzNtjbkz/11KHC796aqMXORnsRWY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wCvnfXqOkW7mOh797h9Xevz2/SPyk1DScs+ep10jd c0=; b=v829HLQF2dqZakU+43b9KPE5sveEwNNBQvn2Mjq/Jv58uNKWpbxHLTK9v 3fAgSeHPdjBzvo2iJUQjNXdZu14c9oXeikEAJ74O4Wvi6p1Yh6o7A02vp0y39uSa Xsq1IKxCe52PNcxYYvGN2ptRy9FGx8v65hak5wFkqOOAi1FYk8G5y0jI0JApVPLh CV2v6TnPFh09TOHTWFN+UzxO7OWJDg/ULS0cpZg/+uVjXFVqLAeMdsY+2CUP7Jwz JyvhbiobM9wnV++gZR3aP3Np97oGU+CuZdWuMhI1EOw0Js5vbEszZxsczKuIQ/MX ckh/SFaW9mdP+Ou01vxzDbBdHwwbA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 329DE80062; Mon, 28 Oct 2019 13:16:20 -0400 (EDT) From: Thomas Monjalon To: Andrzej Ostruszka Cc: dev@dpdk.org, Ray Kinsella , Aaron Conole , Michael Santana , John McNamara , Marko Kovacevic , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo , mattias.ronnblom@ericsson.com, stephen@networkplumber.org, nhorman@tuxdriver.com Date: Mon, 28 Oct 2019 18:16:19 +0100 Message-ID: <1771405.TLjScLWxFJ@xps> In-Reply-To: <035707a2-fedd-6d57-af81-f4942e90f677@semihalf.com> References: <20190917075754.8310-1-amo@semihalf.com> <035707a2-fedd-6d57-af81-f4942e90f677@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 13:12, Andrzej Ostruszka: > On 10/28/19 9:36 AM, Andrzej Ostruszka wrote: > > On 10/27/19 12:31 PM, Thomas Monjalon wrote: > [...] > >> Should we document its use in rte_function_versioning.h > >> and versioning.rst? > > > > Yes, I think so. I'll add that. > > One quick notice. There is a slight mismatch between documentation of > VERSION_SYMBOL/BIND_DEFAULT_SYMBOL and their implementation i.e. the > docs claim that the underscore is added by these macros (b_e) while it > is currently being supplied at the macro invocations. > > I'll try to update docs to match the header but if you'd like to change > it the other way* please let me know. > > Regards > Andrzej > > [*] Change the implementation of these macros to use: > ... RTE_STR(b) "_" RTE_STR(e) > and remove underscore from all invocations of these macros. Please do the doc fix in a separate patch, Cc'ing Neil Horman who can decide what is best. Thanks