Re: [dpdk-dev] [PATCH] telemetry: fix shared build for make

[Thomas Monjalon <thomas@monjalon.net>]

09/11/2018 23:19, Ferruh Yigit:
> On 11/7/2018 6:10 PM, Kevin Laatz wrote:
> > Currently, telemetry is not working for shared builds in make.
> > 
> > The --as-needed flag is preventing telemetry from being linked as there are
> > no direct API calls from the app to telemetry. This is causing the
> > --telemetry option to not be recognized by EAL.
> > Telemetry registers it's EAL option using the RTE_INIT constructor. Since
> > EAL's option parsing is done before the plugins init, the --telemetry
> > option isn't registered at the time of parsing, and as a result, the
> > --telemetry option is not being recognized.
> > 
> > This patch fixes this issue by explicitly linking telemetry to the
> > application by setting the "--no-as-needed" flag for the library in
> > mk/rte.app.mk.
> > 
> > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
> > 
> > Reported-by: Yanjie Xu <yanjie.xu@intel.com>
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks