From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98938A0C55; Wed, 13 Oct 2021 23:11:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AD7A410DB; Wed, 13 Oct 2021 23:11:20 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 9CACB40E50 for ; Wed, 13 Oct 2021 23:11:19 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id ABEAD3200AB0; Wed, 13 Oct 2021 17:11:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 13 Oct 2021 17:11:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= F46B9aRYjuO0TVKL/VfJpahZSGNChq5crQ7hiCJt2RA=; b=YRBcU+z2RJNTRmiS x5OrmU6V4KA23gF/3f3rx2foLlupQxR1ipz74lRUaF8TobpnhaojFYvpSsjGB5ks B+knc/3iJPTrc0t0X+rOzmf2JiO7u34v44iWjLQNbHPMmJml11j6t3Rb1C2ZnMSP rmmRaooMPVt+6nFUR3TNczm6IchfkFPdW4kIrTt82/K4IROa5CG3+3FgnIgHoV/L rt28/nK7ZA87eI4t9xu+HrErYSAlJeYpCKgmbkuU8S1s3Mo8swGeQztJWduPNWhN lDPYr5o5hVs8v7cK4g43Ry5ZOAuQ3Oz9ZtJaqvN9JVMu8IoWGP1iLaHSN/4eAv6r sseh+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=F46B9aRYjuO0TVKL/VfJpahZSGNChq5crQ7hiCJt2 RA=; b=QffyIkH91rXkny8P54EY8esG+9JaE3wISBgEd+JUkFou4mzNn3JWIZbGN 81926bAttx9HOIhDoTjqp2/gd6BI2NvHFPOM3qt59dsi9D4uzE373QG0ZEnerdkI gH9Fbms/lA6nSKPcNSFnrHaVMc3+1+/Z6Xk1DDBcvsLRUD45Ja0o/NcRRFr8hjEB vm3prTBZ/eY5UImpylBgrC/Cd9nXJAU9DG8uehua7UHpSXWGcNITuH1wth/olr4E 9qUgGSKz56O3QteAmPsEJMYELewjizNzA8aJOSSdM93JpvnslTyxWiST1Quq+sAo F6/3g24DnhhCfjGh4yWz04lDaiqGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddutddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtqh ertddttdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepkeethedtieevhfeige ejleegudefjeehkeekteeuveeiuedvveeutdejveehveetnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Oct 2021 17:11:17 -0400 (EDT) From: Thomas Monjalon To: huichao cai Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Wed, 13 Oct 2021 23:11:14 +0200 Message-ID: <1774639.NPN7ftLOvi@thomas> In-Reply-To: <1633764424-17370-1-git-send-email-chcchc88@163.com> References: <1632737174-86870-1-git-send-email-caihc1@chinatelecom.cn> <1633764424-17370-1-git-send-email-chcchc88@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2021 09:27, huichao cai: > Current implementation of rte_ipv4_fragment_packet() doesn=E2=80=99t take > into account offset and flag values of the given packet, but blindly > assumes they are always zero (original packet is not fragmented). > According to RFC791, fragment and flag values for new fragment > should take into account values provided in the original IPv4 packet. >=20 > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper = library") > Cc: stable@dpdk.org >=20 > Signed-off-by: huichao cai We use to capitalize name with family name at last. Is it OK to assume this format for your name? Huichao Cai I see that Konstantin is saying Kevin, is it your alias? Thanks and welcome in DPDK community.