From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDBF5A009E for ; Sun, 27 Oct 2019 12:31:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5074031FC; Sun, 27 Oct 2019 12:31:33 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 19D56374 for ; Sun, 27 Oct 2019 12:31:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 6D949757B; Sun, 27 Oct 2019 07:31:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 07:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2WZhWHeV8w4Q0D98XrA/lh8bfdNpvNoIOM8AFwlmx9Y=; b=LswClewLxsIk eZ7o1Lc8HNAfB92iVOdJoYo1I2lnPUYkPeB9OMUtWDRjpEb6trs2Il752ae9iq/O 9Dudi91DtPfeb/G6AxOpOCSeKdXdbj6bio8aLnD53A7KZjc2UgdpSlCoQpYp6ZqL oD2zrQJlpiMAGqXQibpcplf/4952slI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2WZhWHeV8w4Q0D98XrA/lh8bfdNpvNoIOM8AFwlmx 9Y=; b=pApxzRZOut4928Nf2/c3fnb9WZfO2oSlLm+SSDUawkqn/c8sCO0l1gX15 V2tqT+uLRRRu3F3OzUYza6ugPyNXSsQ+eqr2tNR3LqjihuHtOPzlnPZZWOqACmDy isaMEbQreWVQB8UA4l2+PBMi68gLb3s2hxZfEuyS2jq781uOgxMhER1EqIAMAtnW E4BirTR7YWQJ4VdFpntRU36M/UCOwsn/pcZS6OdXKxkb5EfLMuebIklSUF5r/jVz KiDfqZaEYgXq/Nxk5h5aQXPRFCNrErrge8r9qfRgiwUoELoh7XB6rkIH8Tc+a4W2 cpn/eXH3wlr/DQ84mPLszsR9+wkLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DB915D6005D; Sun, 27 Oct 2019 07:31:27 -0400 (EDT) From: Thomas Monjalon To: Andrzej Ostruszka Cc: dev@dpdk.org, Ray Kinsella , Aaron Conole , Michael Santana , John McNamara , Marko Kovacevic , David Hunt , Bruce Richardson , Vladimir Medvedkin , Robert Sanford , Erik Gabriel Carrillo , mattias.ronnblom@ericsson.com, stephen@networkplumber.org, Andrzej Ostruszka Date: Sun, 27 Oct 2019 12:31:26 +0100 Message-ID: <1775281.ulgepI6dQ0@xps> In-Reply-To: <8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> References: <20190917075754.8310-1-amo@semihalf.com> <20190917075754.8310-2-amo@semihalf.com> <8ba7ce2f-e687-3e1c-c7ab-7749764e80d8@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/09/2019 15:32, Ray Kinsella: > this is cool, good work. > comments below. > > On 17/09/2019 08:57, Andrzej Ostruszka wrote: > > --- a/lib/librte_distributor/rte_distributor.c > > +++ b/lib/librte_distributor/rte_distributor.c > > @@ -32,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq) > > > > /**** Burst Packet APIs called by workers ****/ > > > > -void > > +void __vsym > > all these additional __vsym annotations looks like they belong in a > seperate patch, as they are fixing a bug and are not directly related to > adding LTO the build system. Andrzej, you did not reply to this question. This is a real blocker for merging this series. Should __vsym addition be in a separate patch? Should we document its use in rte_function_versioning.h and versioning.rst? Please explain, thanks.