From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2DFF331FC for ; Mon, 15 Jan 2018 22:28:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 646C52082D; Mon, 15 Jan 2018 16:28:01 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 15 Jan 2018 16:28:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nGR7Tof9Ll2Ih5Xs1NPaigkYd9 ajVs8Btj1NTi1ITwQ=; b=iilUJbbHbLNvOfI1UQO8m1e/KkubdQLQsEOtrZ1cYp U/f1/8iRok+Rn4DwVeyIZngqTXbC5DRzw7K6o5dsRssayqJ3FyGLT+20attCnKr8 5on3TryUEq7GPNA5EFMg3TJrxD7RDNLcq3EwQD1AIiMsNqAGZPZsI+1JmD2p9wgz g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nGR7To f9Ll2Ih5Xs1NPaigkYd9ajVs8Btj1NTi1ITwQ=; b=i6KW3i3LLEGdOnZtEw05Ab i3u7iFqziy0aWMivoNfaHo7gEL27HEwIPaO1W4DfiSNrXI7nYPsTtLa63lV45MY9 ulvYTvDO4vdgZjxuQ12lXWAW4R2lzKprxBtyodYaUCAnoZ5g9vDi3+32ijaySORN 1w/FHejw7gHwuHBq8uX2TO/X4U3hcAmRxPYpkpkbrbnopOAzcp/rML/NuZFOJmeh 7QyTFyQIrIczLA2jE/Bilyc2oMQmsgKWHoDzqrfpaFpDEJGULnEO5KPt/+8294iP b9i+PmXwwlFAMshg9xh9dDn96B+ChslwdpnPe+7NcaZaQsftwsrfdLXYbELwTkLA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0EDF17E322; Mon, 15 Jan 2018 16:28:01 -0500 (EST) From: Thomas Monjalon To: Kirill Rybalchenko Cc: dev@dpdk.org, andrey.chilikin@intel.com, ferruh.yigit@intel.com Date: Mon, 15 Jan 2018 22:27:29 +0100 Message-ID: <1777513.sriIylAOkO@xps> In-Reply-To: <1516037612-69603-1-git-send-email-kirill.rybalchenko@intel.com> References: <1516035500-6010-1-git-send-email-kirill.rybalchenko@intel.com> <1516037612-69603-1-git-send-email-kirill.rybalchenko@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 21:28:02 -0000 15/01/2018 18:33, Kirill Rybalchenko: > --- a/lib/librte_ether/rte_eth_ctrl.h > +++ b/lib/librte_ether/rte_eth_ctrl.h > @@ -662,9 +662,9 @@ enum rte_fdir_mode { > RTE_FDIR_MODE_PERFECT_TUNNEL, /**< Enable FDIR filter mode - tunnel. */ > }; > > -#define UINT32_BIT (CHAR_BIT * sizeof(uint32_t)) > +#define UINT64_BIT (CHAR_BIT * sizeof(uint64_t)) > #define RTE_FLOW_MASK_ARRAY_SIZE \ > - (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT) > + (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT64_BIT)/UINT64_BIT) > > /** > * A structure used to get the information of flow director filter. > @@ -681,7 +681,7 @@ struct rte_eth_fdir_info { > uint32_t guarant_spc; /**< Guaranteed spaces.*/ > uint32_t best_spc; /**< Best effort spaces.*/ > /** Bit mask for every supported flow type. */ > - uint32_t flow_types_mask[RTE_FLOW_MASK_ARRAY_SIZE]; > + uint64_t flow_types_mask[RTE_FLOW_MASK_ARRAY_SIZE]; > uint32_t max_flexpayload; /**< Total flex payload in bytes. */ > /** Flexible payload unit in bytes. Size and alignments of all flex > payload segments should be multiplies of this value. */ > @@ -774,7 +774,7 @@ enum rte_eth_hash_function { > }; > > #define RTE_SYM_HASH_MASK_ARRAY_SIZE \ > - (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT) > + (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT64_BIT)/UINT64_BIT) > /** > * A structure used to set or get global hash function configurations which > * include symmetric hash enable per flow type and hash function type. > @@ -787,9 +787,9 @@ enum rte_eth_hash_function { > struct rte_eth_hash_global_conf { > enum rte_eth_hash_function hash_func; /**< Hash function type */ > /** Bit mask for symmetric hash enable per flow type */ > - uint32_t sym_hash_enable_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE]; > + uint64_t sym_hash_enable_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE]; > /** Bit mask indicates if the corresponding bit is valid */ > - uint32_t valid_bit_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE]; > + uint64_t valid_bit_mask[RTE_SYM_HASH_MASK_ARRAY_SIZE]; > }; This is still changing the ABI. Am I missing something?