From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 803FC3257 for <dev@dpdk.org>; Wed, 12 Jul 2017 12:50:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D5ECA20ACD; Wed, 12 Jul 2017 06:49:59 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 12 Jul 2017 06:49:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qmYJgw6Ynag/Tq8 kZ3IAEjwC5VC3/avYGcvxmbzL5nQ=; b=T5XNKiQpVbIuM5TbghZ2s9zFuUbM17Q GtCknkz7YZjzvu1yjxEytcOUn97hoxmiYQLbDP7a+Ch1m9+UScxzLtN1q0KU8kNc puwgiZb5xctm/NWyMAEFqGFqTJv8wIoiHLEGA5LAd35Z6btwL2lhWHEQ60ycBHlq Y6Rl3QKZ+7ng= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qmYJgw6Ynag/Tq8kZ3IAEjwC5VC3/avYGcvxmbzL5nQ=; b=L91cSoO8 qXxy9w7Y5Rn0AvVAwpf7+w8qkq3b0Pj1w/2ORwvklSw83GcE+Sj35CXwjagNxY6/ KFVwwhGKSLbFl8m8dPg2odqDQjziurWrEn5hlsF9yiPoXe3LCWFSHGjK1tYBiI7s 2qZQgU8OUNXGCqj+VqMeow14HZqIjg3ZbelfT3BZLL70nhkYcdNyzlkt76QEKAku te8ehBDrHam/tCI+g0bjSjb8XKnYObqLZOUmrw8Gb9sbkXsfb0iEuXo85sMtE+O3 Ixd0hJ5igzsyfFBmjyQO6rqZbxC7XWbkD0jsYzoUzwH8eH1kTawhGyzVTAGcG5Gn yBgee6qFRrafsg== X-ME-Sender: <xms:1_5lWWcGkDahITxvFkFlozI5OL1ueTezr0_HZbLm2azc3lynfyKPJQ> X-Sasl-enc: 61uDZv7X4cc8QX1IVziHSzymq1swhhMSG12dbz5g+Mqd 1499856599 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8773C24786; Wed, 12 Jul 2017 06:49:59 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: dev@dpdk.org Date: Wed, 12 Jul 2017 12:49:58 +0200 Message-ID: <1777813.DZOk1ehyER@xps> In-Reply-To: <E923DB57A917B54B9182A2E928D00FA640C3B9E3@IRSMSX102.ger.corp.intel.com> References: <E923DB57A917B54B9182A2E928D00FA640C3B9E3@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 12 Jul 2017 10:50:00 -0000 12/07/2017 10:40, Van Haaren, Harry: > Hi All, > > I propose to add CC: <author> to the output of the git fixline command[1]. > > The logic here is that if it is a fix to the previous code, the original author of that code should be informed. Currently the author must read the mailing-list carefully in order to ensure that no patches are missed, that fix code that they are the author of. > > The new workflow is the same as before: copy the output of "git fixline" into the commit message. The output would now be two lines as follows: > > Fixes: 17b8320a3e11 ("vhost: remove index parameter") > cc: author@domain.com > > > The following git fixline achieves this: > > git log -1 --abbrev=12 --format="Fixes: %h (\"%s\")%nCC:%ae" > > > Opinions? -Harry Good idea. Two comments: - minor nit: CC should be Cc to be consistent with what is suggested by check-git-log.sh for stable@dpdk.org. - Do we want to keep this Cc in the git history or is it just to notify people on the mailing list? I think it is good to keep in history the tags Acked-by: or Reviewed-by:. But if the author does not review the fix, I do not see the benefit of saving his name in the history.