DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Zhigang Lu <zlu@ezchip.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bnx2x: fix undeclared PAGE_SIZE build error
Date: Tue, 28 Jul 2015 11:17:45 +0200	[thread overview]
Message-ID: <1777834.Cdb59hv0LG@xps13> (raw)
In-Reply-To: <1438073298-24683-1-git-send-email-zlu@ezchip.com>

2015-07-28 16:48, Zhigang Lu:
> This patch fixes a build error caused by undeclared PAGE_SIZE when
> compiling for non-X86 arches. On some arches, PAGE_SIZE is not fixed
> so that header files do not define it.  A better way to get it is
> via sysconf(3) or getpagesize(2).
> 
> Fixes: 540a211084a7 ("bnx2x: driver core")

Thanks for fixing it.

> +#define PAGE_SIZE (sysconf(_SC_PAGESIZE))

To avoid conflict with system headers, it would be better to prefix
the constant.
Ideally, we should add RTE_PAGESIZE in EAL and cleanup every usage
of sysconf(_SC_PAGESIZE) and getpagesize.

  reply	other threads:[~2015-07-28  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  8:48 Zhigang Lu
2015-07-28  9:17 ` Thomas Monjalon [this message]
2015-07-29  1:10   ` Tony Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1777834.Cdb59hv0LG@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=zlu@ezchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).