From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 764101B92B; Wed, 25 Oct 2017 12:19:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 125DC20D34; Wed, 25 Oct 2017 06:19:00 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 25 Oct 2017 06:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=3sTZrmYbVswXknfNvTOq+ZwUe9 TJiTWTQGYYS9KOIio=; b=aUk9zKgMvpbABS6QNPADlfOE+8B8nqIgVf0/Jwm3sU H8Unf8DBMS7ZZm40xAbjaV6vlXLUBCHyxqsHG6g0XyTjcMWf0zSCoaqxtBz3ejnh noXetBsVxqvvcPzBo1/ViIZyrww94ehLLxTAo2MZkHVi+BgsnNLAOpDZP2IFlX1x w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3sTZrm YbVswXknfNvTOq+ZwUe9TJiTWTQGYYS9KOIio=; b=iOl1ZFLRCssj2k7iKmRI0e 3j7wqy2eUWp1S5biALBAhdySGrThlr1ZlDD4jXuNzgGEzbyrx86HLknJy3M8+j1Q lRaNyBtizu8ikppXaYgP76X8AUWmGIZi9kvULu5qUSJp0m5uKFugF0yx1pdsrt5h cJuvA6SgHdjmsArUF6BK9t5fxqFPor8ssMIkhj3r3gkxh6mcBvl6ILfhP5IoOh+m xw/47PsBQ4UgJ2gRifCo1HX/hLXlvz7wCGzDCZng+A0Pa1/gMNMvRK3motdvlgNe kPozzmWfQWZiySDT3MYYtHNfZ9j7I7lAPWI5em4vdb01Hqg9zFO86PBpDu/Da+Ig == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CBCD57FA78; Wed, 25 Oct 2017 06:18:59 -0400 (EDT) From: Thomas Monjalon To: Jacek Piasecki Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org, changpeng.liu@intel.com, stable@dpdk.org Date: Wed, 25 Oct 2017 12:18:58 +0200 Message-ID: <1778128.TuySi4b6Nz@xps> In-Reply-To: <1508926038-12821-1-git-send-email-jacekx.piasecki@intel.com> References: <1507808061-37679-1-git-send-email-jacekx.piasecki@intel.com> <1508926038-12821-1-git-send-email-jacekx.piasecki@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] examples/vhost_scsi: fix buffer not terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 10:19:00 -0000 25/10/2017 12:07, Jacek Piasecki: > Use snprintf instead strncpy to get safe null string termination. > There was possible to get not terminated string after strncpy operation. > > Coverity issue: 158631 > Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") > Cc: changpeng.liu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Jacek Piasecki > Acked-by: Maxime Coquelin > --- > v4: RTE_DIM instead ARRAY_SIZE > v3: checkpatch fix > v2: snprintf instead strncpy Applied, thanks