From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C79CA0093; Thu, 28 May 2020 17:03:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E99241DA7D; Thu, 28 May 2020 17:03:56 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7E36C1D9E0 for ; Thu, 28 May 2020 17:03:54 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EE3A25C00D5; Thu, 28 May 2020 11:03:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 28 May 2020 11:03:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= WT7NMyJBo2lumTboRCHJmYuF1wMQ2FQTTAsypL8d1Ig=; b=ixXZXdV8yQfML+vT d0IF2ygZqRQ5QHlun1ThTO5aq0OFW1CD1wkbnN9B2+qiAgAS1o3BmmQIcJx7lxIf ynd26CKcODVuOOZSMCH1sK+wVXT+0EKjD3y2W18fa8tfBk2/yfbNhE+PcgnE7c57 InH8m9jtLiHvHHBAQ2kVkMDmEK+1lt/+aNHVudTQ5hE1EpMiuSfqP0ajv716g7hi qBqqQG1Kyom9NSY66L+LTwlYJ4bZtSPMjlTPoygAtt65oeosEX9Y4ufcAKBR34+h kHD7rA54L8YmpQttUw3iLAEnY/sDwWQ4vxxcBBO9V2BZqbJK4AXc0inLTGiRzK/Y XBLInw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WT7NMyJBo2lumTboRCHJmYuF1wMQ2FQTTAsypL8d1 Ig=; b=ga4tifLosgnour2AQaf/kUW6iXOQBD10pz7kht8R4lvaV/kcfs9EbgRVH 90erENjyaG/VBthF+lvQ4lG5aNu+Fo2z37PyE9DxFLbcSJ2YbsWAyCmOaGlUUE8v VvqedGttM+tGArOAGfDFEoJiTsJX6wqCjeWfXYoPDdDUWIp4gHcziyFkWsK6ky1V P/ChvbsLvlZLGjjqUNdizwcskhXmICdZWvH0DjQ164RLy5vAGYRZ4EuA864h8ZSo qkNb6dIc1JgW0ZMLTmch2DZaZgyURUnSpFj1za4S2XZTV1uA+v+XVFAI5ApX/ksE xnkbmwdD3AKxVra10eKZLf37S6pXA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddviedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F6A53280066; Thu, 28 May 2020 11:03:53 -0400 (EDT) From: Thomas Monjalon To: "Power, Ciara" Cc: "dev@dpdk.org" Date: Thu, 28 May 2020 17:03:51 +0200 Message-ID: <1778495.aMa7JrF7tH@thomas> In-Reply-To: References: <20200128150256.14339-1-ciara.power@intel.com> <2851297.CiCCzYk1py@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] devtools: standardize script arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/05/2020 16:37, Power, Ciara: > From: Thomas Monjalon > >06/05/2020 11:55, Ciara Power: > >> This patch modifies the arguments expected by the check-git-log > >> script, to match the format of arguments for the checkpatches script. > >> Both scripts now take certain argument options in the same format, > >> making them easier to use. > >> e.g. Both now take a commit ID range by "-r " > >[...] > >> - usage: $(basename $0) [-h] [range] > >> + usage: $(basename $0) [-h] [-nX|-r range] > > > >Why not specifying that range can be also the first argument? > >It is a discrepancy with what is documented in > >doc/guides/contributing/patches.rst > > > > I didn't include the old format (that takes range as first argument) here to encourage > using the standardised format moving forward, but anyone that uses the old format > via scripts etc. will not see any difference in use. OK So maybe just add a comment in the script on the old argument parsing to mention it is the old syntax. > I can also update the doc to show this standardised format to avoid discrepancy. Yes please replace with the new syntax in the doc.