From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDE0FA00B8; Sun, 27 Oct 2019 18:39:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9D891BEED; Sun, 27 Oct 2019 18:39:53 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id A0BEC1BEDD; Sun, 27 Oct 2019 18:39:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4E2DB591; Sun, 27 Oct 2019 13:39:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 13:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zb3nUPZr7KWlRlFMjSyglkiIZMUm87tie1KPV6RrBKk=; b=n0EG527NvdIw IoI4GQQegUaoBsT0+p5ZrfSMAVz/iQn40uGlILeB4j5U/8oYvX/mx24822xIvrt4 QEZw7FtvApPkbM+eKXHyUfswmrF02PtyZw2iREZGW3oagOFvoIc9yCA/7cSwB4b1 XHRs+0nFBV3C7tWaJ1671kL9RhFTegY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zb3nUPZr7KWlRlFMjSyglkiIZMUm87tie1KPV6RrB Kk=; b=GXAUqIqHbJBOy6AtROnFCmCY9MDI8PAF/eBsM8eiWfGALNw4Fou7OHzy/ DTycLLhZ/59MviNmAViz6UBk4NH/7Tt+BLVjMLocyiyIAtksYcPXuCRwawT29Jq+ SMyB1RdtVB5EOhHHijYZolja8ORl8jQont7MRWyYS8BOjbIep6/BUcYrWzAv48Q8 z5o/uYx3RKGGjKyLl1mblYOXj8janaMfyCNRGSnsck3+JntvL1/nm+5gqMI9Dhe1 cL+gID+Ff/atYPDK5jHPD7cKo7Fi71jNVtkkqnPmkogZxs7/Ye4ij4SnFIarBWbe BZEE1+zWE1bAablQxn3yibdQ95Mog== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C2A8580063; Sun, 27 Oct 2019 13:39:48 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Xiao" Cc: stable@dpdk.org, "Hunt, David" , dev@dpdk.org, "Liu, Yong" Date: Sun, 27 Oct 2019 18:39:47 +0100 Message-ID: <1779321.6W3n8sOxgi@xps> In-Reply-To: <17d41a58-909a-0650-eac2-0ffe33081ca8@intel.com> References: <1568131814-48424-1-git-send-email-xiao.zhang@intel.com> <2827869.UTeVd217Fa@xps> <17d41a58-909a-0650-eac2-0ffe33081ca8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] examples/l3fwd-power: fix RX interrupt disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/10/2019 10:07, Hunt, David: > > On 23/10/2019 15:32, Thomas Monjalon wrote: > > +Cc Dave, the maintainer > > > >>> Interrupt will not be received when disabling RX interrupt without > >>> synchronization mechanism sometimes which leads to wake up issue, > >>> add spinlock to fix it. > >>> > >>> Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when > >>> waking up") > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Xiao Zhang > >> Reviewed-by: Marvin Liu > > This makes sense, as the corresponding rte_eth_dev_rx_intr_enable() > already has a spinlock around it. > > Acked-by: David Hunt Applied, thanks