From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 65AB35A52
 for <dev@dpdk.org>; Mon, 15 Jun 2015 17:02:04 +0200 (CEST)
Received: by wiga1 with SMTP id a1so80759552wig.0
 for <dev@dpdk.org>; Mon, 15 Jun 2015 08:02:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=J2q6QRMPSMCs0jeFJECSjVn0WyP2C+GQGJ7V5AsdsRU=;
 b=XInWWGvjgcFujRpvcIBV2vzH4P9uv3RHmGco0RYaLEtoh5qRpS1ARbB04QAjVzIPyB
 tRqAy+/bjDJx2UXcLXmONWLxNG1VpgaAPIfK2AexPEnT766yqQwOi3n46A61t+YuZPY3
 YYIk4iDGpLdnWwnTfzAGBD1jppB+hUpAY2/PAKcPEGzXjLVpOyNq0SFoDdxs3DKMCA9G
 lC7Xh8+L/dFxVHppUzDUOei8bVbArKK6/lEzRwZ7KhPcDJguQ6ilJyGpXWmhxTRZ/IBL
 l7F3QEy4M5eruNAuxaV5MrIlYBcACG+/QShzB345F66Mf/dAXAUQMArTNeStm1tDho3z
 iEkw==
X-Gm-Message-State: ALoCoQmms0Q1UgDEUngNAQNl2xgj1tkBIW/4+yvLtVnZKsVszRRFk52TQy+EMm/H1K11fkJSlJuM
X-Received: by 10.180.73.10 with SMTP id h10mr32997836wiv.3.1434380524263;
 Mon, 15 Jun 2015 08:02:04 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id r6sm16282257wiy.13.2015.06.15.08.02.02
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Jun 2015 08:02:03 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: nhorman@tuxdriver.com
Date: Mon, 15 Jun 2015 17:01:07 +0200
Message-ID: <1779695.4NFurMfay9@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1434094441-23906-2-git-send-email-helin.zhang@intel.com>
References: <1433403216-7114-1-git-send-email-helin.zhang@intel.com>
 <1434094441-23906-1-git-send-email-helin.zhang@intel.com>
 <1434094441-23906-2-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add an field for querying
	hash key size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2015 15:02:04 -0000

2015-06-12 15:33, Helin Zhang:
> v3 changes:
> * Moved the newly added element right after 'uint16_t reta_size', where it
>   was a padding. So it will not break any ABI compatibility, and no need to
>   disable it by default.
[...]
> @@ -918,6 +918,7 @@ struct rte_eth_dev_info {
>  	uint32_t tx_offload_capa; /**< Device TX offload capabilities. */
>  	uint16_t reta_size;
>  	/**< Device redirection table size, the total number of entries. */
> +	uint8_t hash_key_size; /**< Hash key size in bytes */
>  	/** Bit mask of RSS offloads, the bit offset also means flow type */
>  	uint64_t flow_type_rss_offloads;
>  	struct rte_eth_rxconf default_rxconf; /**< Default RX configuration */

Neil, what is your opinion?
Do you ack that this technique covers every ABI cases?