[dpdk-dev] [PATCH] examples/pipeline: fix strtoul base

[dpdk-dev] [PATCH] examples/pipeline: fix strtoul base

[Churchill Khangar]

This patch addresses the issue with strtoul base

Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands")
Cc: cristian.dumitrescu@intel.com

Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index e97e120..631c325 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -53,7 +53,7 @@
 	if (!isdigit(*p))
 		return -EINVAL;
 
-	val = strtoul(p, &next, 10);
+	val = strtoul(p, &next, 0);
 	if (p == next)
 		return -EINVAL;
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base

[Thomas Monjalon]

05/03/2021 16:15, Churchill Khangar:
> This patch addresses the issue with strtoul base

Which issue?
Please explain what is broken and how it is fixed.

Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, March 24, 2021 9:05 AM
> To: Khangar, Churchill <churchill.khangar@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; P,
> Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>; Jangra,
> Yogesh <yogesh.jangra@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
> 
> 05/03/2021 16:15, Churchill Khangar:
> > This patch addresses the issue with strtoul base
> 
> Which issue?
> Please explain what is broken and how it is fixed.
> 
> 

Nothing is broken here, this is incorrectly labeled as a fix. This is simply an small improvement to allow specification of integer arguments for the CLI commands in hexadecimal ( and octal :) ) as well as decimal, as opposed to just decimal.

Churchill, it would be great if you could update the title and description to reflect this as opposed to claiming a fix, and send v2, thanks!

Regards,
Cristian 

[dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

[Churchill Khangar]

This patch allows specification of integer arguments for the
CLI commands in hexadecimal and octal as well as decimal.

Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index ae06658..ef49eb8 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -55,7 +55,7 @@
 	if (!isdigit(*p))
 		return -EINVAL;
 
-	val = strtoul(p, &next, 10);
+	val = strtoul(p, &next, 0);
 	if (p == next)
 		return -EINVAL;
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

[David Marchand]

On Wed, Mar 24, 2021 at 1:20 PM Churchill Khangar
<churchill.khangar@intel.com> wrote:
>
> This patch allows specification of integer arguments for the
> CLI commands in hexadecimal and octal as well as decimal.
>
> Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>  examples/pipeline/cli.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
> index ae06658..ef49eb8 100644
> --- a/examples/pipeline/cli.c
> +++ b/examples/pipeline/cli.c
> @@ -55,7 +55,7 @@
>         if (!isdigit(*p))

Not directly related to this change, but the isdigit() check is
probably useless.
strtoul returns the first invalid char.

>                 return -EINVAL;
>
> -       val = strtoul(p, &next, 10);
> +       val = strtoul(p, &next, 0);


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

[Dumitrescu, Cristian]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 24, 2021 12:31 PM
> To: Khangar, Churchill <churchill.khangar@intel.com>
> Cc: dev <dev@dpdk.org>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; P, Venkata Suresh Kumar
> <venkata.suresh.kumar.p@intel.com>; Jangra, Yogesh
> <yogesh.jangra@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args
> 
> On Wed, Mar 24, 2021 at 1:20 PM Churchill Khangar
> <churchill.khangar@intel.com> wrote:
> >
> > This patch allows specification of integer arguments for the
> > CLI commands in hexadecimal and octal as well as decimal.
> >
> > Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> >  examples/pipeline/cli.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
> > index ae06658..ef49eb8 100644
> > --- a/examples/pipeline/cli.c
> > +++ b/examples/pipeline/cli.c
> > @@ -55,7 +55,7 @@
> >         if (!isdigit(*p))
> 
> Not directly related to this change, but the isdigit() check is
> probably useless.
> strtoul returns the first invalid char.
> 

Yes, correct, more improvements could be made, we'll put it on the to-do list. Thanks, David.

> >                 return -EINVAL;
> >
> > -       val = strtoul(p, &next, 10);
> > +       val = strtoul(p, &next, 0);
> 
> 
> --
> David Marchand

Re: [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

[Thomas Monjalon]

24/03/2021 13:22, Churchill Khangar:
> This patch allows specification of integer arguments for the
> CLI commands in hexadecimal and octal as well as decimal.
> 
> Signed-off-by: Churchill Khangar <churchill.khangar@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.