From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B9376B62
 for <dev@dpdk.org>; Thu,  1 Nov 2018 10:27:04 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 45E1322276;
 Thu,  1 Nov 2018 05:27:03 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 01 Nov 2018 05:27:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=tb/4z0djSfKHwfOuvGCi4Gpgena2QHV2DK4h3QpuvLs=; b=NIBscIbdGHNY
 iYB0AUQP/fJtqeZCh2RqC81R4eGOO7QkLDQs78pH5oTQIHUHEjXBuIeGYB1b/iuY
 LaU12QMCFybskWt75xBbzK75YxMISKWhe1VBpbnc4+iJSgMy/wbPuM3ia96BbRFM
 jw2ZvQGIDMq/N1nOTaWfDj3ZQYlikuw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=tb/4z0djSfKHwfOuvGCi4Gpgena2QHV2DK4h3Qpuv
 Ls=; b=J44lPzuhZXJtIK3bP6VpvNIdf4dh6GQjLxcFKwFYZTMge8OJ/9AXutJjr
 St2r0/krOQky0BNKQHWaHC3xIYOokYk0dHpgSHww6eM0faipzqnj53UZYuftACdT
 pfbgtUu4N1mi5/aJiBBOF6b9sZYh6mLHpf7zd6FeVwKnDX0RbThwOwyptozuqvoQ
 0b21V7qpQ+B/0ZhRQwzHvckcPHrcXlMXSfBEGF7uyQAgsx8TULOAmQSS0xKub3h2
 qoCPv0wR9oalZaqGVkQ2f2ol2GaV/6XLDzMThHVhDP8pTPcCCOmFuOkTEI7qn659
 ++Oxnytkc7C1TGtl6DSlzymVhrZNw==
X-ME-Sender: <xms:5sbaW0Xod-OKZeDp9xjpkqozk5JDixnvVO4HpEVElQSBxlzNZV_Vzw>
X-ME-Proxy: <xmx:5sbaW8f7_txuanxPAKcTO-sGA5HxcH2sIhOp06IKAWF1a2RNqfE7Cw>
 <xmx:5sbaW1O-aD_J8dAadGNuMHtorMMFwfndGp2_OuoFwmtrNSlU690iPQ>
 <xmx:5sbaWyipBfcQ7EZH_0c8O5UYdLX7J8V3DHMIoA-KQggRE4NscWli1w>
 <xmx:5sbaWw0EY71wGpHk2quc4hwXo_V5c0_oWdwzNuMUqNucShtMK8YNkQ>
 <xmx:5sbaW0idCUg4Ko_zetLGjO6miTlycHIiMbkzkWehqpq2u52yWJnQ_w>
 <xmx:58baWxSZLu4uyLJk4nbHscDmbPutPidQbHkHnf3NbAUrFi-219qpsg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1A8D71040E;
 Thu,  1 Nov 2018 05:27:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Date: Thu, 01 Nov 2018 10:27:01 +0100
Message-ID: <1782447.EoLl64vPQU@xps>
In-Reply-To: <CAKy9EB3PL9vFV7H6xEwiskBcyQEfEXPfnV6xMv=XVoEUUwsFrQ@mail.gmail.com>
References: <20181031110548.31184-1-thomas@monjalon.net>
 <20181031162842.19431-1-thomas@monjalon.net>
 <CAKy9EB3PL9vFV7H6xEwiskBcyQEfEXPfnV6xMv=XVoEUUwsFrQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] devtools: check wrong svg include in
	guides
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2018 09:27:04 -0000

01/11/2018 07:45, Arnon Warshavsky:
> Hi
> 
> >PS: the warning contains the regex. May it be improved?
> 
> How about passing an explicit warning message to the awk instead of the
> regex?

Yes it is a good idea.
I think it can be a separate patch. Would you like to send it please?

[..]
> +       if [ $? -ne 0 ] ; then
> +                ret=1
> +       fi
> +
> +       return $ret
>  }
> 
> I also noticed that there is a need to keep the return value from each
> check in case the first fails and the latter succeeds

No need of return code.
The error is detected if there is something printed to stdout.