From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, jianfeng.tan@intel.com,
qi.z.zhang@intel.com, stable@dpdk.org,
Paul Luse <paul.e.luse@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vdev: fix rte_mp_request_sync() memleak on scan
Date: Thu, 25 Oct 2018 16:06:32 +0200 [thread overview]
Message-ID: <1782616.ReFsLbzSkl@xps> (raw)
In-Reply-To: <20181025104735.137381-1-dariusz.stojaczyk@intel.com>
This patch was already sent, reviewed and applied.
Why do you re-send it?
25/10/2018 12:47, Darek Stojaczyk:
> rte_mp_request_sync() says that the caller is responsible
> for freeing one of its parameters afterwards. vdev didn't
> do that, causing a memory leak.
>
> Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
> Cc: jianfeng.tan@intel.com
> Cc: qi.z.zhang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Paul Luse <paul.e.luse@intel.com>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> drivers/bus/vdev/vdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 688e31c21..685cc4e78 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -425,6 +425,7 @@ vdev_scan(void)
> mp_rep = &mp_reply.msgs[0];
> resp = (struct vdev_param *)mp_rep->param;
> VDEV_LOG(INFO, "Received %d vdevs", resp->num);
> + free(mp_reply.msgs);
> } else
> VDEV_LOG(ERR, "Failed to request vdev from primary");
>
>
prev parent reply other threads:[~2018-10-25 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 10:47 Darek Stojaczyk
2018-10-25 14:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1782616.ReFsLbzSkl@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=paul.e.luse@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).