From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 5F1CF5F1A; Thu, 25 Oct 2018 16:06:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id F37A5C8B; Thu, 25 Oct 2018 10:06:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 10:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/pcMkeDw0r16PVAkdYCPFfD/m86UKzVLrh+9IOe+QcM=; b=bJXXStWlPYgo ix7gFpvQsyA8O21fuuAXbhQ1q3utayIskXoG33W+2cNbuEHdm8j/6Pq5leXVHufg xpd2EVEoNi/UyDaMNQTylbXZDB9iCH+At7mTeg+JyDRnIkUut0mr7NLzYw/DJqTf zlXspZXF69NWUu2TFzzTclANzW+EEjY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/pcMkeDw0r16PVAkdYCPFfD/m86UKzVLrh+9IOe+Q cM=; b=kZ/6vwF6Ii4nbvhJ15PCsSvpEF0BJsfWqeTecyP2DmV1UK02AU4EuSck3 GZWXYH3oOx0+s2an2kj/YgqFvSYSCDlt9DGBTD/VvToFRMqFTdfu3zBKiIpD9QG6 +4gP3OA/Ty+jTuNw9IZ2vLCnrklkSg2k2FqFvEWZXtpk5rIqp/B85G+OQtFTi9lq Ac+Gq8ORcLh/2kFw6qXnInQeUnXFBA7DwR/prc4lhqAWaRnlB0aFJUvg7vbz40L4 WZaDRvRzrd89b4jgqdXiFHDoVYJfVsE/7RSW9ZBBYObCp2zdKvbUngCIqxACc8WP sAV9NNc6q86wTPfSjZuJuhxC7DOvA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1A35E4074; Thu, 25 Oct 2018 10:06:29 -0400 (EDT) From: Thomas Monjalon To: Darek Stojaczyk Cc: dev@dpdk.org, anatoly.burakov@intel.com, jianfeng.tan@intel.com, qi.z.zhang@intel.com, stable@dpdk.org, Paul Luse Date: Thu, 25 Oct 2018 16:06:32 +0200 Message-ID: <1782616.ReFsLbzSkl@xps> In-Reply-To: <20181025104735.137381-1-dariusz.stojaczyk@intel.com> References: <20181025104735.137381-1-dariusz.stojaczyk@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vdev: fix rte_mp_request_sync() memleak on scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 14:06:34 -0000 This patch was already sent, reviewed and applied. Why do you re-send it? 25/10/2018 12:47, Darek Stojaczyk: > rte_mp_request_sync() says that the caller is responsible > for freeing one of its parameters afterwards. vdev didn't > do that, causing a memory leak. > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") > Cc: jianfeng.tan@intel.com > Cc: qi.z.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Paul Luse > Signed-off-by: Darek Stojaczyk > --- > drivers/bus/vdev/vdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c > index 688e31c21..685cc4e78 100644 > --- a/drivers/bus/vdev/vdev.c > +++ b/drivers/bus/vdev/vdev.c > @@ -425,6 +425,7 @@ vdev_scan(void) > mp_rep = &mp_reply.msgs[0]; > resp = (struct vdev_param *)mp_rep->param; > VDEV_LOG(INFO, "Received %d vdevs", resp->num); > + free(mp_reply.msgs); > } else > VDEV_LOG(ERR, "Failed to request vdev from primary"); > >