From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 78D5442F6C;
	Fri, 28 Jul 2023 17:20:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4BAA140685;
	Fri, 28 Jul 2023 17:20:33 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 07CF54021E
 for <dev@dpdk.org>; Fri, 28 Jul 2023 17:20:32 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 966035C0107;
 Fri, 28 Jul 2023 11:20:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Fri, 28 Jul 2023 11:20:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm3; t=
 1690557631; x=1690644031; bh=kX+XNbBTK0nGNxIzr6ZVvkOY1m9ltPtV9mq
 6REdOm5g=; b=IvAeFpjlmfCkRDWcizsZGE2039LEYPZFzkrNQGQa31tp3I0Kxwr
 IFR2d+o1m2ZW1ll1jLF1kJKHDBXqmg2eHXOlItUTmr4za6qPBpefQWHM/2HCUNXD
 XVCFqtsHYNVFlU87sg/rL9gT1NHqH03CKlH5RgbsC0nmINV0cvY/eMSUNkb0f4/L
 DzpALCNNv0iz2fe204mDvMvRmAcgVM6mBTeuqANyiHSjCctNktIJ/MsyvkRoHsKS
 RpYseRln14jZZS4Z5xXduwBHFeLVGbul0Y9qUh9ew5n0PVRr6pmfbuyHr/V8H9Sb
 Tfd+zxZKtpsxFOvtBkmG+YL3LIgRhckTk0g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1690557631; x=1690644031; bh=kX+XNbBTK0nGNxIzr6ZVvkOY1m9ltPtV9mq
 6REdOm5g=; b=Rix7vskD1rF89TsnL74I7Sdgex0DrVSajwzTF2jb6vhwOYH6V8m
 8ginqLYHnc2PfQvNsAnVO5vjb5AkkGDZfk4Fv28ogf5gR5vqchpBJMnIjFrGShZH
 sWlspCtVWLXbcgT39FyzxrM29Z9yVHYHNZ7x2vkCvlkdHqbQ4sIoI9uGI8C4KX2C
 Yn621MQkYaACVwWbVac7f+bfPeORSSk8uOlJy9BU6ALdm/0rxZn12u78/ptHGeA9
 /OGjZwIL0XDnfC9AShmrWx5ouOIgUvwcEzltYl76muy8+Jcpb4TaLGoZkyqxPLcC
 Q9YYm3aj2kAJjSmb45E71ME+BygwLypxJCQ==
X-ME-Sender: <xms:v9zDZP0o2V7OygJYKBXLlxUV9K1Jq-wEiOqSNh_PJ9JK1zseGBCvkw>
 <xme:v9zDZOHde_ROVwR38tEYdQyCycd0bRXTaR5XoXX8deRTD1RXll3KiTK15hziL_DcY
 Nkbl6kq6MkMyugYmA>
X-ME-Received: <xmr:v9zDZP724QJhcTMHTw86OVgwXmEx1KI82DvwNLgYxzdCQyFN_5nByZUJlpcqgzM2NrC-vIUUJ6JIMZ4nkJ3-neX9KA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigdekgecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev
 tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:v9zDZE3KKXnJQHUO1bHWowFcdsn1niJEVlRz6O9R3dSqdrZu5ieIzA>
 <xmx:v9zDZCEVzKOKlkVfXWjs7RWfUZiH6SSVeVyYG3mo6zN7nu58yqEwfg>
 <xmx:v9zDZF9BM7IE_HlfGQF9lvSpU19hRDp5NasQbKX0iYprZeYR6H_c7Q>
 <xmx:v9zDZAabFOJfr6m_zfdfTL5KDM7waeZ_gU6gH9rsliAm4eMep8nD7g>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 28 Jul 2023 11:20:29 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Cc: dev@dpdk.org, nd@arm.com, Honnappa.Nagarahalli@arm.com,
 Feifei Wang <feifei.wang2@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>,
 Feifei Wang <feifei.wang2@arm.com>, ferruh.yigit@amd.com,
 konstantin.ananyev@huawei.com, andrew.rybchenko@oktetlabs.ru
Subject: Re: [PATCH] doc: announce ethdev operation struct changes
Date: Fri, 28 Jul 2023 17:20:28 +0200
Message-ID: <1783013.TLkxdtWsSY@thomas>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87AA2@smartserver.smartshare.dk>
References: <20230704081006.1202932-1-feifei.wang2@arm.com>
 <2352864.NG923GbCHz@thomas>
 <98CBD80474FA8B44BF855DF32C47DC35D87AA2@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

28/07/2023 17:08, Morten Br=F8rup:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Friday, 28 July 2023 16.57
> >=20
> > 04/07/2023 10:10, Feifei Wang:
> > > To support mbufs recycle mode, announce the coming ABI changes
> > > from DPDK 23.11.
> > >
> > > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > > index 66431789b0..c7e1ffafb2 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -118,6 +118,10 @@ Deprecation Notices
> > >    The legacy actions should be removed
> > >    once ``MODIFY_FIELD`` alternative is implemented in drivers.
> > >
> > > +* ethdev: The Ethernet device data structure ``struct rte_eth_dev`` =
and
> > > +  the fast-path ethdev flat array ``struct rte_eth_fp_ops`` will be =
updated
> > > +  with new fields to support mbufs recycle mode from DPDK 23.11.
>=20
> Existing fields will also be moved around [1]:
>=20
> @@ -83,15 +90,17 @@  struct rte_eth_fp_ops {
>  	 * Rx fast-path functions and related data.
>  	 * 64-bit systems: occupies first 64B line
>  	 */
> +	/** Rx queues data. */
> +	struct rte_ethdev_qdata rxq;
>  	/** PMD receive function. */
>  	eth_rx_burst_t rx_pkt_burst;
>  	/** Get the number of used Rx descriptors. */
>  	eth_rx_queue_count_t rx_queue_count;
>  	/** Check the status of a Rx descriptor. */
>  	eth_rx_descriptor_status_t rx_descriptor_status;
> -	/** Rx queues data. */
> -	struct rte_ethdev_qdata rxq;
> -	uintptr_t reserved1[3];
> +	/** Refill Rx descriptors with the recycling mbufs. */
> +	eth_recycle_rx_descriptors_refill_t recycle_rx_descriptors_refill;
> +	uintptr_t reserved1[2];
>  	/**@}*/
> =20
>  	/**@{*/
> @@ -99,15 +108,17 @@  struct rte_eth_fp_ops {
>  	 * Tx fast-path functions and related data.
>  	 * 64-bit systems: occupies second 64B line
>  	 */
> +	/** Tx queues data. */
> +	struct rte_ethdev_qdata txq;
>  	/** PMD transmit function. */
>  	eth_tx_burst_t tx_pkt_burst;
>  	/** PMD transmit prepare function. */
>  	eth_tx_prep_t tx_pkt_prepare;
>  	/** Check the status of a Tx descriptor. */
>  	eth_tx_descriptor_status_t tx_descriptor_status;
> -	/** Tx queues data. */
> -	struct rte_ethdev_qdata txq;
> -	uintptr_t reserved2[3];
> +	/** Copy used mbufs from Tx mbuf ring into Rx. */
> +	eth_recycle_tx_mbufs_reuse_t recycle_tx_mbufs_reuse;
> +	uintptr_t reserved2[2];
>  	/**@}*/

Removing existing fields should be announced explicitly.