From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f179.google.com (mail-we0-f179.google.com
 [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 93DC0A6A
 for <dev@dpdk.org>; Mon, 23 Mar 2015 15:32:29 +0100 (CET)
Received: by wetk59 with SMTP id k59so139453194wet.3
 for <dev@dpdk.org>; Mon, 23 Mar 2015 07:32:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:mime-version:content-transfer-encoding:content-type;
 bh=AmHvJIomnY6wJIrnr8vQMPi6F7EPU4ahOXpCEgkr2Yw=;
 b=iojwhqLghiIM/LsUcJjZJ3zvN4Ov+nSDtoNxk5G7FYKL0W4VyQek404XM4jy3oQp1/
 t4G5/GaSe2RuQszqcjNj8P8GQ2Q8/s8yY8FjplpwZMeJQcWReGkd3t2siyRnWGENbGa6
 j9A61iBynT13sfJUmyUtfVSngH/ELjBhZAYgkt83DaNS3XOHDMhMWm+AD61AQuisyDJE
 HzEeubprr2IfIQQWGjJu3IoG0s0NyRmQRchfLE6pz/yXnilCEBSEAPTfXQ0JNwQFLGLp
 lTOWaWRbHJeu+KNobBvQvILYFke+67i9tEdW+khhDJFciv7d7MAZWRAFsfFv+3vJVFQC
 lOtQ==
X-Gm-Message-State: ALoCoQn8JfNMVD2W5HdswGAhg/G1IkRNROiW7EpoCo3IacmV2QUtLNfEBh46uN02foM8ftc71qe1
X-Received: by 10.194.236.200 with SMTP id uw8mr180610779wjc.10.1427121149408; 
 Mon, 23 Mar 2015 07:32:29 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id cf12sm1669446wjb.10.2015.03.23.07.32.28
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Mar 2015 07:32:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
 John Mcnamara <john.mcnamara@intel.com>
Date: Mon, 23 Mar 2015 15:31:48 +0100
Message-ID: <178390751.P840gF6HAz@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: [dpdk-dev] Rx/Tx callbacks in debug mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2015 14:32:29 -0000

Hi,

As you may know, rte_eth_rx_burst() and rte_eth_tx_burst() have a
debug-specific implementation enabled with RTE_LIBRTE_ETHDEV_DEBUG.
I'm afraid these implementations have been forgotten when adding
optional Rx/Tx callbacks. Or is it intended?

What do you think of removing these debug functions and insert extra
checks with ifdef in an unique function?