From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD875A0350; Thu, 25 Jun 2020 01:05:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C9815F2F; Thu, 25 Jun 2020 01:05:37 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B2F885B3C; Thu, 25 Jun 2020 01:05:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3EA7F5C00F7; Wed, 24 Jun 2020 19:05:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 24 Jun 2020 19:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FHbRld9ULo3Ub6adiRGOJ1Lg8I6hAKZzvxQkNZnF7bQ=; b=ldRASsSimq0crXb9 nIfdtxm8C+QdGtTIMs4ieZ6QJbkOcLoj0ZVlVGqJZ75W9yWNWkK8huANx+WaBTP7 NXlkOpXqvSnE4YkfE1tD3ooNF9a9gpJmcNWe05oyiC7ejnGHTxhRfK416nrwApEI zJYnjjbEy0DTT46b2F+IrY2zXJ0X0vz1FKiu1w8GjO6BLrFIvRs/jySorlkv734u eYq1uCjWoOYZjne3K7Jbt4N4gQPUC47bQdqSs/lGOILprqDj9m8sL8YNOR2tIobX 3XTL89u6OwclCb538re2cLAKewCr7QtPtivblR33XTWrM2z4UbcNap5LGmDKMkCX /iVigQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FHbRld9ULo3Ub6adiRGOJ1Lg8I6hAKZzvxQkNZnF7 bQ=; b=WPN+V8HwV1b/U1xgmx2nITycvziexpbNJXZP6nT0rf8fiaoOv03J5AP1F wf7Q/H0Lk7+LLdgRvq+N2ysFfXDUTgqqc8qMqCbfE0F/728IprB18l2ZcMZY4Nwn ran2DkLkFzj7N3kgcxerxlCZYpQMqmCcwl2MwV4fyp600MRh0k/lZ4Kojdf1Yqfa aE80AYeZlr+4XLXkdB3S377rCQQo76Qz1khv0JBEK/I4ZvZzkX/1NTnQrXomKOrU EVzL7azmYpAmj7rpOf1W3P3Hn03h6IH8PUN35yU9gUBAk9Khp2isyysNEOZEINJL iGNYjWK+kiqbJRAbNRAEl0UrZ84gw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekkedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5339C3067705; Wed, 24 Jun 2020 19:05:35 -0400 (EDT) From: Thomas Monjalon To: Long Li Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger , stable@dpdk.org Date: Thu, 25 Jun 2020 01:05:34 +0200 Message-ID: <17849898.BQ2eLMOKaY@thomas> In-Reply-To: <20200612090633.1a3d90a7@hermes.lan> References: <1591922905-81259-1-git-send-email-longli@linuxonhyperv.com> <20200612090633.1a3d90a7@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/vmbus: calcuate the correct start address for mapping ring buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/06/2020 18:06, Stephen Hemminger: > On Thu, 11 Jun 2020 17:48:25 -0700 > longli@linuxonhyperv.com wrote: > > > From: Long Li > > > > vmbus_map_addr is used as the next start virutal address for mapping ring > > buffer. However it's updated based on ring_buf, which is a pointer to an > > address on the stack. The next ring buffer may be mapped to an unexpected > > address. > > > > Fix this by calculating vmbus_map_addr based on returned virtual address. > > > > Signed-off-by: Long Li > > > Fixes: 3f9277031a2e ("bus/vmbus: fix check for mmap failure") > Acked-by: Stephen Hemminger +Cc: stable@dpdk.org Applied, thanks