From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69ADEA0471 for ; Wed, 17 Jul 2019 23:01:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C12F3977; Wed, 17 Jul 2019 23:01:08 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 5E5FF2BBB for ; Wed, 17 Jul 2019 23:01:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 173F33BD; Wed, 17 Jul 2019 17:01:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Jul 2019 17:01:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rXQp34HeHkxMvjWj+uuVN+U+8WKNEfXNg4ICrgBA5Kc=; b=YPtfFHGrs88u Qv40dUZHWBjGURnPrEj8/r9PWJfF7WNsh6x7MwwtwDomhAFUcRZB3G5VDrWr3N8W UfdZJY0jwJZtLYNY1+5fVoGA3NwzS/xB3S5ryyb945SoRClV7DXbf4/RRXccBAoH mXUacKe835Inn+QTXCVjwmDHd/ACu28= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=rXQp34HeHkxMvjWj+uuVN+U+8WKNEfXNg4ICrgBA5 Kc=; b=ZyJHsMen4X9DEHJhC/LJ690kP0fXB76p3G1CDeDAReB1HDtz/9jUrsVM2 dq2EYiC80CzS59pwElzO0MNUOtyne2zf7LzO5TDllfN4+zK3Igvrqe6G7oGJ2J29 /38jlU2WgHsplpmbnHbRgzLshlIJNtWS9L939ETsWsXFVYepuWjiM8vcZwD4zqNe DAUGpecdwM8JdcZWLlZ9sMYJV2t15LV2zfH15Z+7Zt+XGZNXhiIkSsmClOBJ8J9Q Nz8aig0LY3ieHRPhhrXUj898yz8cZ1Wxl1Occ6uqRfCZ6KsCgzw56katP6W8/eLV yCL3bWSDJquUkzMJrQNkspG1j/2NQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieefgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B8C2B380089; Wed, 17 Jul 2019 17:01:03 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com Date: Wed, 17 Jul 2019 23:01:00 +0200 Message-ID: <1785181.DCrEJ4CubZ@xps> In-Reply-To: <20190716172741.21399-3-stephen@networkplumber.org> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190716172741.21399-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2019 19:27, Stephen Hemminger: > In general, DPDK libraries to not print error messages to > stdout because that is often redirected to /dev/null for daemons. > This patch changes cfgfile library to use RTE_LOG with its > own type. > > Signed-off-by: Stephen Hemminger > --- > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -62,6 +62,7 @@ extern struct rte_logs rte_logs; > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > +#define RTE_LOGTYPE_CFGFILE 21 /**< Log related to cfgfile. */ As you know, we are supposed to use dynamic logging now. Let's stop to add new static log types here. Better, we should plan to completely drop these types.