From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue
Date: Tue, 16 Dec 2014 17:36:57 +0100 [thread overview]
Message-ID: <1785187.jrxsoh9Kkn@xps13> (raw)
In-Reply-To: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com>
2014-12-12 12:15, Ouyang Changchun:
> The following commit break vm2vm hard mode test cases:
> commit db4014f2b65cb31bf209cadd5bcec778ca137fe2
> Author: Huawei Xie <huawei.xie@intel.com>
> Date: Thu Nov 13 06:34:07 2014 +0800
> examples/vhost: use factorized default Rx/Tx configuration
>
> Investigation show that it needs enabling vlan offload since it is turn off by default,
> and Tx need it, especially when vm2vm is in hard mode.
I missed something here. Where VLAN offload is disabled by default?
Could you point the code, please?
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -390,6 +390,9 @@ port_init(uint8_t port)
> txconf = &dev_info.default_txconf;
> rxconf->rx_drop_en = 1;
>
> + /* Enable vlan offload */
> + txconf->txq_flags &= ~ETH_TXQ_FLAGS_NOVLANOFFL;
> +
> /*
> * Zero copy defers queue RX/TX start to the time when guest
> * finishes its startup and packet buffers from that guest are
>
next prev parent reply other threads:[~2014-12-16 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 4:15 Ouyang Changchun
2014-12-12 6:00 ` Fu, JingguoX
2014-12-16 16:36 ` Thomas Monjalon [this message]
2014-12-17 0:51 ` Ouyang, Changchun
2014-12-17 10:04 ` Thomas Monjalon
2014-12-17 23:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1785187.jrxsoh9Kkn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).