From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 82E7A7F49
 for <dev@dpdk.org>; Tue, 16 Dec 2014 17:37:28 +0100 (CET)
Received: by mail-wg0-f54.google.com with SMTP id l2so17888853wgh.13
 for <dev@dpdk.org>; Tue, 16 Dec 2014 08:37:28 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=pasucdWml4pK8rqnsT30GrkxF1BLszgT+9I9hzdL8z0=;
 b=VoFUh9KL6+pq+GP6OgAtOmXtZ78huJ7o5RGTCCUFOGibOL7+cAK8NAWn44bQqrIEVn
 lgI2Qe4xu66kcMZvVxqbfDX5Tfjhz60MWE5egf+3cPGdhGDyQ40jzkI7VdB+pHocvs0K
 iaTLlykEm60iH8HfEipnXkYBvEdRpEps4ox5+T+2fWWiYcduCZ9ds9bqRFdfMb4gvPdd
 sAVbSHkWPEe/bNtfVwffbb9PO31CLZwWII027meEYVSheWkp0njIMAnWUZazdme8cVCB
 JWJN0KmK+eMdWySc32JWYKjPQeeQjCrvQNMJIgs5gxKQSi1P/iKKgvrEVnmA+ZVe5j9j
 cvgQ==
X-Gm-Message-State: ALoCoQl/BarcjCptWh5c9nfXIyDRxc0WSLLM9U0KlIvJ/OG4UaPyUij7Uzp/ca/w2JSKu408Je5v
X-Received: by 10.194.60.19 with SMTP id d19mr30735401wjr.48.1418747846989;
 Tue, 16 Dec 2014 08:37:26 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id dv9sm2735712wib.14.2014.12.16.08.37.22
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 16 Dec 2014 08:37:23 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ouyang Changchun <changchun.ouyang@intel.com>
Date: Tue, 16 Dec 2014 17:36:57 +0100
Message-ID: <1785187.jrxsoh9Kkn@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com>
References: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 16:37:28 -0000

2014-12-12 12:15, Ouyang Changchun:
> The following commit break vm2vm hard mode test cases:
> commit db4014f2b65cb31bf209cadd5bcec778ca137fe2
> Author: Huawei Xie <huawei.xie@intel.com>
> Date:   Thu Nov 13 06:34:07 2014 +0800
>     examples/vhost: use factorized default Rx/Tx configuration
> 
> Investigation show that it needs enabling vlan offload since it is turn off by default,
> and Tx need it, especially when vm2vm is in hard mode.

I missed something here. Where VLAN offload is disabled by default?
Could you point the code, please?

> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -390,6 +390,9 @@ port_init(uint8_t port)
>  	txconf = &dev_info.default_txconf;
>  	rxconf->rx_drop_en = 1;
>  
> +	/* Enable vlan offload */
> +	txconf->txq_flags &= ~ETH_TXQ_FLAGS_NOVLANOFFL;
> +
>  	/*
>  	 * Zero copy defers queue RX/TX start to the time when guest
>  	 * finishes its startup and packet buffers from that guest are
>