From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning
Date: Thu, 26 Jun 2014 14:22:13 +0200 [thread overview]
Message-ID: <1785970.8gmsnpVZCs@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A746859@SHSMSX104.ccr.corp.intel.com>
2014-06-24 14:43, Ananyev, Konstantin:
> Yes, it is much nicer to fix it in i40e_lan_hmc.c.
> But I don't really want us to open that door.
> So my vote would be to initial Mark's patch: add '-Wno-error' in the
> Makefile.
2014-06-24 15:25, Zhang, Helin:
> We should not modify code in shared code, if we do not want to maintain
> those huge code base. I think Mark's patch good for now, we can report that
> issue to shared code maintainers, and try to get them to fix it later.
2014-06-25 05:36, Chen, Jing D:
> my committed patch to ignore the warning on that file and continue the
> compile . By doing so, the logic is right and didn't change code's
> behavior. We also needn't maintain it. Even in bad case we find bugs
> hidden behind the '--CFLAGS_i40e_lan_hmc.0' warning in future, we can fix
> it after bug occurred. That's simple.
Applied for version 1.7.0.
Thanks
--
Thomas
next prev parent reply other threads:[~2014-06-26 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 5:22 Chen Jing D(Mark)
2014-06-24 8:46 ` Thomas Monjalon
2014-06-24 9:47 ` Chen, Jing D
2014-06-24 10:06 ` Thomas Monjalon
2014-06-24 14:43 ` Ananyev, Konstantin
2014-06-24 15:25 ` Zhang, Helin
2014-06-26 12:22 ` Thomas Monjalon [this message]
2014-06-25 5:36 ` Chen, Jing D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1785970.8gmsnpVZCs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jing.d.chen@intel.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).