From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id CF933B0B7 for ; Thu, 26 Jun 2014 14:22:00 +0200 (CEST) Received: by mail-wg0-f52.google.com with SMTP id b13so3525880wgh.35 for ; Thu, 26 Jun 2014 05:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3MUGxtqT8lT+J8gs/ejNYQj3/Ynnp7Sbq2BP93zvQ8Y=; b=PgaGHjt8XVuo0pR+ZLlLotRwJrRisTEVSl6bQhk8DshDFSevCjI/CqE4cvVG1Z583k TIaCtQrefMGHn52eBIcF4XzS3+TaTpC+IXtSsQz32AaA7B0uY6cjToQAYODeWHVTBJ2d Tf2r+xr2Ki/QDHrPukUK9fydInOScI8Dr5P1acTDRvSSiajFIgraV6Sv9J2N2xeeP8v+ IQFXE/SAonNnpu57wdLrhMm3rGZpMH2m6PUCfzz6tj52IUCOgZxX5DyNobW7p1frwJeF w/ryv8d9/sqUohcoKFctDYR3CEUsL4xnNln0Y3iv8kplJWkj+bvQtJ/uhdHmQA3tLedx bkVQ== X-Gm-Message-State: ALoCoQkqcJN9rnVKT5qaHrsVX4HM0g5y6nF7/wyRFhVRQsWr1lc+X/1HIABp6Xin7oHKuYZTHxMQ X-Received: by 10.180.211.144 with SMTP id nc16mr3859809wic.43.1403785339438; Thu, 26 Jun 2014 05:22:19 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id s3sm14137982wje.36.2014.06.26.05.22.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jun 2014 05:22:18 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" , "Ananyev, Konstantin" , "Chen, Jing D" Date: Thu, 26 Jun 2014 14:22:13 +0200 Message-ID: <1785970.8gmsnpVZCs@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: References: <1403587377-10287-1-git-send-email-jing.d.chen@intel.com> <2601191342CEEE43887BDE71AB97725821333FA3@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix shared code compile warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2014 12:22:00 -0000 2014-06-24 14:43, Ananyev, Konstantin: > Yes, it is much nicer to fix it in i40e_lan_hmc.c. > But I don't really want us to open that door. > So my vote would be to initial Mark's patch: add '-Wno-error' in the > Makefile. 2014-06-24 15:25, Zhang, Helin: > We should not modify code in shared code, if we do not want to maintain > those huge code base. I think Mark's patch good for now, we can report that > issue to shared code maintainers, and try to get them to fix it later. 2014-06-25 05:36, Chen, Jing D: > my committed patch to ignore the warning on that file and continue the > compile . By doing so, the logic is right and didn't change code's > behavior. We also needn't maintain it. Even in bad case we find bugs > hidden behind the '--CFLAGS_i40e_lan_hmc.0' warning in future, we can fix > it after bug occurred. That's simple. Applied for version 1.7.0. Thanks -- Thomas