From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BC0BA04B7; Tue, 13 Oct 2020 17:47:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8761DDAA; Tue, 13 Oct 2020 17:47:53 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 8908E1DD9C; Tue, 13 Oct 2020 17:47:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 38638AF7; Tue, 13 Oct 2020 11:47:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Oct 2020 11:47:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= wpUFRYtcelXaQh+NOnPJSFLns7GEFXQpBpkl11C5Uvc=; b=fofVnGZvjp+9ZAc0 SDKrNqmIoo6toAgWbIgz1bvD9mFflmfaGe0BrmN7o7G4R6Kt9jT2+Ss7jD3fVzPk EHnIt8qYWucHVaU7viLLjdFfmMKVCGTeE0yj2KQztejS0GKhjVyabVT/wzubJUZ8 4/Iv2+XqKvmc0+TzRA9lxtvotvaKpROwBTymgZZt6g0iE/KuOE4HAu8qvqggqlEJ sLjOCtnyZpLWZM1iNo97rSSgdPzsEMGNZCPPTPbdIWr35CgkUMgR6ZIvQl6DCBrQ t3Ft9NYwKhc1l5Dg4lJ4U7sCnV9HVGduSPlmRq+A/I/un66En922o+H0TFt2N1p+ 8/FWOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wpUFRYtcelXaQh+NOnPJSFLns7GEFXQpBpkl11C5U vc=; b=d0FSp2Q8kD2Sra8dmbFYb2LBqRWkGbKQjwXfKStbaz0JVBq/NL/J/pgiD W8ddY2Y5CzRUuFJbGr9+vntoTf8WZ/+8rPyoMtv/F8KiZQBZRblqNg2KNAbpKs1K DDk1FuehmHA1PAbajXYLSN6/gpapwikyA3cQOY3+S82MY3uGm2vqaM8NRNzVXmPU Gmh/9LtMb1HGFHIBr+R07s1BSAiMdeJsndfzfd87uj7B+onnX7l7rFXjztympKyt VlGu6sUlLhQokZIj48nAW/I6q+3UpkOyD8RYfgiwqrUhZGb1WjXG4KHPhCpOW2NK s3RFPONrZY7jMCCrpf2bP86ZyuiPg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheelgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 93A1E3280059; Tue, 13 Oct 2020 11:47:46 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Ferruh Yigit Cc: dev@dpdk.org, Andrew Rybchenko , "techboard@dpdk.org" Date: Tue, 13 Oct 2020 17:47:45 +0200 Message-ID: <1787812.87Z69qtDSk@thomas> In-Reply-To: <8f8907cf-d905-c867-cf42-694d16b0a0cf@intel.com> References: <1602600818-7473-1-git-send-email-arybchenko@solarflare.com> <8f8907cf-d905-c867-cf42-694d16b0a0cf@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/10/2020 17:32, Ferruh Yigit: > On 10/13/2020 3:53 PM, Andrew Rybchenko wrote: > > Use ENODEV as the error code if specified port ID is invalid. > > > > Signed-off-by: Andrew Rybchenko > > --- > > lib/librte_ethdev/rte_ethdev.c | 44 ++++++++++++++++---------------- > > lib/librte_ethdev/rte_ethdev.h | 46 +++++++++++++++++++++++----------- > > 2 files changed, 54 insertions(+), 36 deletions(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > > index 5b7979a3b8..1f862f918a 100644 > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > @@ -784,7 +784,7 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, char *name) > > { > > char *tmp; > > > > - RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > Thanks Andrew, +1 to this error unification. > > This will be API change without deprecation notice, cc'ed techboard for it. This is an error code change, unifying assumptions across ethdev, I would say yes to merge in 20.11.