From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 9CA088D86 for ; Wed, 2 Dec 2015 12:26:36 +0100 (CET) Received: by wmvv187 with SMTP id v187so249953316wmv.1 for ; Wed, 02 Dec 2015 03:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=zRPI+T9JIZE3x9WyFwqQRr49GxBrYGpdjJFWb3ZZ0SQ=; b=Lxc81Yny3uHbdaujLR//e+4HxU+0jv0X41Wti3WhEoNVI6N848ftr3JCakbFWtO0bB daKb5VFShfBeJz9Th1t2p7kog66fl1WXNC0rjx9B+UucFTBC1KWw82KH/FJ2+OZYkpnx pTGdmQBAuwyJT3DEq73oIT5bUji2Uq31aDpnqEKY+DrQqoRtmmp0E215LXXWagtupoDf UVTE5Xwmqem++2K/nr8YYJaiRkvXZrUkoVfRD4N/LnsMHuCRNZjgSMzBrrtgNGe4lv3y UzjDZlZmpD1uqMTsKKnS0QprtiIdarqTy3AzCD6cC8Yh2u5nCnCvvnuR3ETCBij79CpU bM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zRPI+T9JIZE3x9WyFwqQRr49GxBrYGpdjJFWb3ZZ0SQ=; b=Y3LOMpAWEmwEYSa2upXiLIrrnPrmoitL+hY83zRlzC+WfNu9BGMMhN1nH/eUZGIMX5 k2dfs7JzGPBtV25/kk3yTSSgNKVaMV/1Ve9nqz+shcnFWx4m4qKbjxDtRB2lxehLGqpq MSEsEFI7WQZnI+BEVwVGkRa3OAwt2nh6V7oKiDzcyFFxBxqWAwCrfq+ta/pUQJsFBn8F Wjj8nbSRepkj2zdf1+yepGoIWHJqvW53NojMtLd+w9Iyb49ihMfExRyGt8LOXLGA1ZX5 m9dZpKjxPhLPasuabYFjWfGN2heJlyo6ixoU0cVcfUI7I51nqgX8+UxFrqrjh/nKcZ5A d77g== X-Gm-Message-State: ALoCoQkORM2/lv0Q10NWsdkE5ePHQT670rZ8daorb5qm0AGrg9Crw/eJc2BRyFEthi7Z8+aF6kLu X-Received: by 10.194.8.35 with SMTP id o3mr3941639wja.153.1449055596465; Wed, 02 Dec 2015 03:26:36 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id qm9sm2321252wjc.39.2015.12.02.03.26.35 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 03:26:35 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Wed, 02 Dec 2015 12:25:26 +0100 Message-ID: <1789607.LxQySkSOJm@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <565EC77B.6060807@redhat.com> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1449028676-19232-4-git-send-email-thomas.monjalon@6wind.com> <565EC77B.6060807@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 03/10] mk: install a standard cutomizable tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 11:26:36 -0000 2015-12-02 12:27, Panu Matilainen: > On 12/02/2015 05:57 AM, Thomas Monjalon wrote: > > The old installed tree was static and always had .config, includes and > > libs in a RTE_TARGET subdirectory. There is no such directory anymore in > > an installed SDK. So the top directory is checked. > > But RTE_TARGET can still be used, especially to build an app with a > > compiled but not installed SDK. > > That's why both cases are looked for RTE_SDK_BIN. [...] > > The old usage of an installed SDK is: > > make -C examples/helloworld RTE_SDK=$(readlink -m $DESTDIR) \ > > RTE_TARGET=x86_64-native-linuxapp-gcc > > RTE_TARGET can be specified but is useless now with an installed SDK. > > The RTE_SDK directory must now point to a different path depending of > > the installation. [...] > > + $(Q)$(call rte_mkdir, $(DESTDIR)$(sdkdir)) > > + $(Q)cp -a $(BUILD_DIR)/.config $(DESTDIR)$(sdkdir) > > + $(Q)cp -a $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir) > > + $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(sdkdir)/include) > > + $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(sdkdir)/lib) > > $(prefix)/share is supposed to be shareable across different > architectures. Most of the content here is, but at least the lib symlink > and .config file are not. The case you want to address is multilib 32/x32/64, right? > One option is to install .config and the symlinks within $(sdkdir)/$(T) > directories, then it can be shared across architectures because each > lives in their own directory. Another possibility is moving the whole > sdk directory into a subdir in $(libdir), but that misses the > opportunity to share across architectures (whether anybody actually > cares is a whole other question :) Yes, I tried to remove the use of RTE_TARGET when building an example. But we can keep it with a subdirectory in $(sdkdir). > $(sdkdir)/lib -> $(libdir) symlink seems reasonable when installing to > an empty staging root, but on a real-world installation it'd point to > /usr/lib(something) which has hundreds or thousands of other unrelated > libraries. My memory is hazy on details but I think this caused an > actual problem with something because I ended up $(sdkdir)/lib an actual > directory populated with symlinks to the individual DPDK libraries. I don't see the problem. I suggest to keep it and see how to fix it if an issue is raised.