From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 086671B611 for ; Fri, 22 Jun 2018 15:44:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 925E521C0E; Fri, 22 Jun 2018 09:44:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 22 Jun 2018 09:44:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=h59i1vgQ6hgO4f+Aqf7gc0E+Dr QTlhTSqxAl9pPcYME=; b=cSLC+O2bqwpJbT4skdQPQpoirk1exCxgoqPuvmg0ND 1c8QF3la0ce/JFXo2OaHN4gWR5FXuVOxWf4VCYS3pd+uZGXOvv53g+/WbZy6xfqx NvmvxOwJgYSIj2DWqm2RN/OHhvsPIF/NN0AEzF4SgHNvGtzFZ6pvvZnMy23384iA o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=h59i1v gQ6hgO4f+Aqf7gc0E+DrQTlhTSqxAl9pPcYME=; b=bQJNRQmeFv9f8mlyg6zwrA hhOJ8tu4T3RhUBc8jXusamWSLkywZPHrMkjIWbJwTmhEhRUMRLzXkd9j2IJqEbGA u13VKHNQLyNGWK+PweHnXAlmZ1r4alhyYirvl7/nXdb5h8jjW7sc0+tcyrqxRmoP uHTT3Jb256/l9pD+cGKYszy29OwUOfUhuxsK8Gv12O2nexFIXzuQBVNzioMccAid Z27HenfQFmllPdQwxk+qQvwl8ThIcWC8gEZEEDjpOMqyfyo9aWI6iI2xzr4iB9XL sPZb6keoYfKwbosKKuPgMccIeFk0rJqB94ywGaRsmhgHp7V/X77nYEh/veIdFj4Q == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D512CE4270; Fri, 22 Jun 2018 09:44:52 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: Stephen Hemminger , "dev@dpdk.org" Date: Fri, 22 Jun 2018 15:44:51 +0200 Message-ID: <1789949.7rL1TaZSp4@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB71A8@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-1-stephen@networkplumber.org> <20180618213557.15209-4-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260CB71A8@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/3] examples/l3fwd: format the IP addresses for printing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 13:44:54 -0000 22/06/2018 12:23, Iremonger, Bernard: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Monday, June 18, 2018 10:36 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v3 3/3] examples/l3fwd: format the IP addresses for > > printing > > > > It is better user experience to print standard format for addresses rather than > > raw hex. > > > > Signed-off-by: Stephen Hemminger > > --- > > examples/l3fwd/l3fwd_lpm.c | 15 ++++++++++----- > > > > dpdk/devtools/check-git-log.sh -1 > Wrong beginning of commit message: > It is better user experience to print standard format for addresses > > It is complaining about "It" in the commit message, not sure why. > > Hi Thomas, > > Could this be a bug in the check-git-log script. No it is not a bug, just a pedantic warning :) Look at this commit for the explanation: http://git.dpdk.org/dpdk/commit/?id=9c24780f0d5efd