From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 09ECE1BD12
 for <dev@dpdk.org>; Mon, 14 May 2018 01:33:52 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6C77425CDD;
 Sun, 13 May 2018 19:33:52 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Sun, 13 May 2018 19:33:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=TlLsPWY1E2kf/7AxSu0EAD/iND
 d6yB4oRHyJzZHHcDQ=; b=jMmWOF/yeMxOOXk8VQGv+SFP2ONL0/rZGM7kel5lRA
 2mgf8DCvg7zWJnEbhiv2BSFqsk3HS1GYxQe2nPVlDJILezavNApmAYiiWii32fWF
 NzwUqWncxsjU3QYYflRapyThaeyB/7grSNyEcd99nwmd9cPuorwIAbPUXbSKsZe8
 U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TlLsPW
 Y1E2kf/7AxSu0EAD/iNDd6yB4oRHyJzZHHcDQ=; b=Iqmxqn9gN8BGoXaYNrWwLU
 fCCz4JrJkGU1/QFV+liY0Ld5RIrwUr1Lsj1DL12allIOHTiHowulnzYoalCXzei4
 oVUlKWoeQWp17WNjxDy1p5qMFyI9TuI5p0pqgEGWx7C/X+/7MheI/4obnIC5l478
 UfRASsy5k6Nf0tXyeEspuPzbzskR7JlS7eGWtUL+EAInDbvCnK6j7Kk8C+8mE+uG
 4HbM/aT0GwRcK3ZGn8XokfjnRBJjET+H5uLGfXNHftZOU74oBxkxz7L55JGWkuEA
 A8sN2kooCCKYDmwoOxJuMyULmCaBMt5szhMExAXHlCEpePJDVgMK2vrkE4u9e2+A
 ==
X-ME-Sender: <xms:YMv4Wq9tq-516zqJbJc41jigVaBgJNsgcpZ5oxCJuvg8K4pGBunISg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id BEAC5E4443;
 Sun, 13 May 2018 19:33:51 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Date: Mon, 14 May 2018 01:33:50 +0200
Message-ID: <1790443.DjOxLm43Na@xps>
In-Reply-To: <1968691.VWAu9saNLK@xps>
References: <be863f870fc02ea6464d15c87fa43e9d274f3240.1524155435.git.anatoly.burakov@intel.com>
 <4409303.1sNuYAC1ue@xps> <1968691.VWAu9saNLK@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 23:33:53 -0000

08/05/2018 22:20, Thomas Monjalon:
> 02/05/2018 23:00, Thomas Monjalon:
> > 30/04/2018 14:50, Bruce Richardson:
> > > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote:
> > > > When we ask to reserve virtual areas, we usually include
> > > > alignment in the mapping size, and that memory ends up
> > > > being wasted. Wasting a gigabyte of VA space while trying to
> > > > reserve one gigabyte is pretty expensive on 32-bit, so after
> > > > we're done mapping, unmap unneeded space.
> > > > 
> > > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > > > ---
> > > > 
> > > > Notes:
> > > >     v2:
> > > >     - Split fix for size_t overflow into separate patch
> > > >     - Improve readability of unmapping code
> > > >     - Added comment explaining why unmapping is done
> > > > 
> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > I am not confident pushing this change post-rc1.
> > Please can we have more validation tests with this patch?
> 
> Any news about validation tests?

No news, but I've decided to push it anyway.

Series applied