From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 47AA65583 for ; Wed, 4 May 2016 18:26:20 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id a17so103904070wme.0 for ; Wed, 04 May 2016 09:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=n5CreOROXAmquhvzF6ZGyof0wnTkYXPOULgZyiTO5JQ=; b=bz752V4LfVVNw2YRD+5rrGKQS90njzgo3eNiSprfcsf6N72qpcXjp7cV5g1IV+E5oo D2svBKgTnHaJr6Hk3Kbe56zuxuf/Ww/ntnOZpRct+kPaConh8DX1kIyQ4cD8z3gRPf0E WSnFFnOPBPQwcsPFrB/AwqnHli5knopvrSY1c35rFFOYbHGGepwH/+q8//an+HG0yrep fYRuJ+PO/jGSKME/G7PXXv9uDUUy5JBgeK8N70LoIAI7OglrVcgFbBQmKleufJ/qyJC4 gHpoF8YmosXiRHVzslwFwkmn+wwN1ofuc/M0ZHtSfU48Km4xsMsI6OByy5K0nmQl6X4C E0sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=n5CreOROXAmquhvzF6ZGyof0wnTkYXPOULgZyiTO5JQ=; b=lsmd3G5Xz+DfrF+IpVjeFkQeMRZaEdnnVUXn287T1eZLyy/bCrwrHkKcMzo+68gkG6 TxSySWWiGsFJjbujpPazOxosMDZmGCcj+0PAqI4l+ZRYAGmGgMjHunuFsyutvKb6FzE3 /9vvi0k36o9k9OCqyLSx5kockO+6NRqFGcObxAndGl8AijIM87AYA2FeyzpQpsiqffwR WGN3q163zmK5UZivaHtFmB4WATPj7eu49cz1f60sMHEbIsbCdlGc3xlo4k5cshqc2rXy vb4NJdBZ3C09USH8YukQrbhSF+IGS5uU2QooPN+6hQ9l8jImn29IX5S7mIGgBAFQgEvV aCvQ== X-Gm-Message-State: AOPr4FW0RQWuYs4a6NFZFxY1Fl3axu0MMEikwT9UHjrf6zpsZh4dcSqswlFGdAeFXSGlK2V/ X-Received: by 10.28.45.216 with SMTP id t207mr10017354wmt.40.1462379180126; Wed, 04 May 2016 09:26:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m14sm5156167wmc.4.2016.05.04.09.26.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 May 2016 09:26:19 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: David Marchand , dev@dpdk.org, viktorin@rehivetech.com Date: Wed, 04 May 2016 18:26:18 +0200 Message-ID: <1790773.lrclFWmpAI@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160504152517.GA10164@bricha3-MOBL3> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-13-git-send-email-david.marchand@6wind.com> <20160504152517.GA10164@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 12/17] pci: add a helper for device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2016 16:26:20 -0000 2016-05-04 16:25, Bruce Richardson: > On Wed, Apr 20, 2016 at 01:44:12PM +0200, David Marchand wrote: > > eal is a better place than crypto / ethdev for naming resources. > > Add a helper in eal and make use of it in crypto / ethdev. > > > > Signed-off-by: David Marchand > > --- > > lib/librte_cryptodev/rte_cryptodev.c | 27 ++++----------------------- > > lib/librte_eal/common/include/rte_pci.h | 25 +++++++++++++++++++++++++ > > lib/librte_ether/rte_ethdev.c | 24 ++++-------------------- > > 3 files changed, 33 insertions(+), 43 deletions(-) > > > FYI: I see a compile error after applying this patch. It's unrelated directly to > this patch as root cause seems to be rte_debug.h missing an include for > rte_branch_prediction.h It's probably due to this recent commit: http://dpdk.org/browse/dpdk/diff/lib/librte_eal/common/include/rte_debug.h?id=50705e