From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
by dpdk.org (Postfix) with ESMTP id 813FA2BFE
for <dev@dpdk.org>; Sat, 5 Mar 2016 19:59:24 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id n186so33130197wmn.1
for <dev@dpdk.org>; Sat, 05 Mar 2016 10:59:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=I7qbCjcQ9Zz62U5ipSDPR4NU6hsyluKqVvdao218nEg=;
b=sHPD9gOXE2TCnG747hX/oWdJlgKMZPRGvY1U1dkuRKnw/5g8nOUtTHj816+s4OM9Fa
xW3cL3lmt8LROFAxiUIUVzhBGrDiVh5VGO9XOaQ9CdvKQMXksTVScPQLZGOPMmbs5ECQ
apNvJBLFbqGGhtlbpldskoQ8ad28RysBry2zj5Dyx22RNngLWemI60pMioB0ji6t2d/V
tVvKHHO+zuhMybE0Y+PLI36X1B/tN91xjzJ5j6Rhc13GP+tPvSzneXTPhlPseMpC2IBG
nZAj7473I2irfBb48qkCN002MKE5pJevddtCX8Pq87KQD0yX4jf8TLeRJ8q0OaMQb0cP
CzBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=I7qbCjcQ9Zz62U5ipSDPR4NU6hsyluKqVvdao218nEg=;
b=Sn6R96e7rYKkh0lNItoWKxxhy+Q3Pz9nNxlQUxSdZUsu+1jO/vnCeRNjDT9wNUUzzl
mwQM/J/DdOCmbiwSw30UWbPvIO3J8nwpr+ZQSbOxsbXREC3+w8RD22holmSEae1m9F6Q
o4AdlDRlVDZ6IPn4iMsbtdBuTPWKrvGEP59Z7ca8HN0oP3zWN98G3zG/vx9j3JbeYE5f
K5rOPKYzh0I0YBGye6acrmRU8xAPXOQOOISRoeCuaUwcyhDezexpBcwVQ0CbGS4Cgfvo
7gp8ea34/auMrMf0Svb9s/wNtcpmXdQHHs+j5dfIy/e1UXfHVGH/JyaG6txfK9kuYZtZ
gvSg==
X-Gm-Message-State: AD7BkJJslJVHVcMfb/oxozE4EbuLMQgMunsqUyKDDySnSbjyDl5Tm/gSPg8Gh99hbBHrmbvD
X-Received: by 10.28.220.134 with SMTP id t128mr4677459wmg.61.1457204364371;
Sat, 05 Mar 2016 10:59:24 -0800 (PST)
Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171])
by smtp.gmail.com with ESMTPSA id jf6sm9386323wjb.2.2016.03.05.10.59.23
(version=TLSv1/SSLv3 cipher=OTHER);
Sat, 05 Mar 2016 10:59:23 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Date: Sat, 05 Mar 2016 19:57:47 +0100
Message-ID: <1791028.uxNtJnaPXX@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C8A0236@IRSMSX108.ger.corp.intel.com>
References: <1454647823-26663-1-git-send-email-xiao.w.wang@intel.com>
<E115CCD9D858EF4F90C690B0DCB4D8973C8A0236@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] testpmd: fix wrong prompt in tx_vlan
set command handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Mar 2016 18:59:24 -0000
> > When using testpmd, sometimes we forget the right order of port_id and
> > vid in "tx_vlan set (port_id) vlan_id[, vlan_id_outer]\n" command, and
> > input "tx_vlan set 51 0", we'll get a strange prompt saying "Error, as
> > QinQ has been enabled.".
> >
> > In cmd_tx_vlan_set_parsed function, the first thing we do is checking
> > the port's vlan_offload capability, rather than checking validity of the
> > port_id, therefore if it's an invalid port_id we'll get the above wrong
> > message. We should always make sure that we get a valid port_id before
> > we do other things.
> >
> > It's the similar issue for cmd_tx_vlan_set_qinq_parsed function.
> >
> > Fixes: 92ebda07ee58 ("app/testpmd: add qinq stripping and insertion")
> >
> > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks