From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 346164575E; Wed, 7 Aug 2024 17:38:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F7F9402D3; Wed, 7 Aug 2024 17:38:21 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65]) by mails.dpdk.org (Postfix) with ESMTP id B82EF4028C for ; Wed, 7 Aug 2024 17:38:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t3kvOPKkxb4VR9uQXC6UOs2DsSLErzaJG+jAagfX6EWlbAKLFhJAfBCtgablTLy4pPJjphik4i5XfzaQWb8xiVbDdxdMasYngT1yqqov7LgwuHLTrThZDsRenCCkNWoIXpTZgMscsd49w+cL4/JxZtArfGTvlCuAzBl8dxGRi36clP1H8QgZm6NCv/VifsiNzJTYFoY2oNiOykVplaMOHN/Zze8qJQNtR+MKtp2mc2J5Uzt7D1DWXlXk7bGjGH4wcKVAUJ91pQ+eoM1hS89NOOA+hCMnPB3od0FIhYF1wOpPnVDVFrTHz4stNmo7HcpxvwfQgYB4gUhPVFeVUIzuSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T69wrP04Da0fl92rY4JQUSUQj07XuFsjvGwvL21E/Uw=; b=j492uMcar86QOkGubWFryxcuPdlYu8DlQMEHCnK07HG1oufcACC2NsQEE1XRYj+kr8FNxTpmccH9hc8OmERFjRXV87es6Y+3JAMFebnuHCbktwCdfDFai5mJ8g2ArzLKoEDjn3Ur5DZdAjrwKbVtNdyaXRoadpZLONqeUVG0dzmkFSVs3KhMWw4VpY38v9DwDibgcCtHGb7G56XGhKCt5KUia8W6mK6X09Bm73xwD7WU0sy5h5/tKfU6RtEsqFpcZVvKTU2OcV2uhKXF/ZyHPaJdWwegwunfHqu090c2E8zqwVeuXmXRxmAHDGI3QjenaKZQ6RYv8HJXKHwKX6MdUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T69wrP04Da0fl92rY4JQUSUQj07XuFsjvGwvL21E/Uw=; b=RCGse744SDPO4P7gCEzTL8wwn+H1IJUvtAlFzUvmmIcKdjDEL4tAR1SmlNWQjExscj+WYvgzKLQXD7U4hdGBKTCPhYl5Wi5nRUkahBKjlPXuKj3xk0ceglTfXa/C2HTkbgTs6FYRPceK3i/09PCal+/pk/JFl+X/Vt6J+DHQ9U4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7344.namprd12.prod.outlook.com (2603:10b6:806:2b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.23; Wed, 7 Aug 2024 15:38:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7849.008; Wed, 7 Aug 2024 15:38:13 +0000 Message-ID: <1791f469-ab2c-466a-aa87-a195b7a187de@amd.com> Date: Wed, 7 Aug 2024 16:38:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/17] bus/dpaa: add port buffer manager stats To: Hemant Agrawal , dev@dpdk.org Cc: Gagandeep Singh References: <20240801105313.630280-1-hemant.agrawal@nxp.com> <20240801105313.630280-5-hemant.agrawal@nxp.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240801105313.630280-5-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0021.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7344:EE_ X-MS-Office365-Filtering-Correlation-Id: addb07ac-b0b1-4817-4b7c-08dcb6f6f30c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NnIzWGVtUlllRkhnQytIZldMUTExWWJVUjZUdjJUZkM3clA4SFNnVDJSaU9H?= =?utf-8?B?WXViUGlzUXU5YjY4TDR2YXUrUkNDL0MyM29Oa1NnZ1N0YzNVNm5XU0ZLa2hB?= =?utf-8?B?bTRUeWpwUTAwcmVWbmpHTTl1WWo1T0dNQ2RIbzFaVmlOWUFLd0Q4c2JJZVVM?= =?utf-8?B?UUNEUzN4TkM1NjJHTERvUDIzeUZ1V29sdHY2VEw2ZGZlQnJwWU5NUDJjK1dS?= =?utf-8?B?T2VoODAxSkdUU1E1d3pkU1VudUFjV0R1SHNmY3Z3amlXVXo0eVJpM3paTjY3?= =?utf-8?B?T0p5ZzlManRpeURnZ2dtdWEwSjdKSU51d1VMMTBsczF2aDhaUE1QNnZORlVs?= =?utf-8?B?dUJNZlpqN3BwOWY0U3lRNVZTWHJNNnFDUHF3d002YkZhY2g2MWZwNDg4aU9T?= =?utf-8?B?MFlXeVkzVnlBQ0ZTVDZRdXZiRmlrNHM5OE5FS01neVMrL01kNWw3L3hBeEh2?= =?utf-8?B?Z29MTmR6Smh1Zys5Q2ZWV2h3OGcrb2xWTDdnS21vd3M5TnIwdnpzK3g3SUlK?= =?utf-8?B?K0llQk82MlBqRnowSnpYTWp2Wnh6dnlmOGNOazhSclBkS3V2NXZGdGUvcDBN?= =?utf-8?B?WERIQk1objBTaHlqcVhFOFAxRDNycFJDcDhMcnI1M0lJWDdvdWoyY0RkN2dk?= =?utf-8?B?clQ2S3JqcEMxQndMT0FSNy9VY2ZsNERTVXdEOU1HUVU4dWNRam0wM3FnZmNw?= =?utf-8?B?RmF2RCtXV3NFMHI3QnRqdS9OVWtISWY1QS82UkdFWHk4NGhBQzZkSkMvZWVm?= =?utf-8?B?QWVsOU1LQTcxOG9jQ3R6cVZ0R0xOMjBtaFVOUElwRzRrbVZ1VUVybXBXRmhI?= =?utf-8?B?TW1rM0w0L1BKdkY4NkFsTDg0UVplT0hqb3pmVnZGTmtDQ3lOazQ0amZIam9j?= =?utf-8?B?cXc1bC9GdGlqcEp1OWJySEtLQUl4RHZaQnEreGZ5dUMwdTdKWElkMXNJRkpP?= =?utf-8?B?b1NNbUZscTYxQnNFWjF1QlBFdzE3T2pQSG0wNXhUdk8xVCtCd05HeDlJNkFW?= =?utf-8?B?b3pxcit6N2VUWGRSZnlrZTBiQTF2NjBlUVRIL0Y5eVNRamNkQmRGTGJLYlBw?= =?utf-8?B?UXBZR3k5RkV1SWN6MWR1ZDlXcDhZZmZsMnJ4V2w0K01GNGZKa1VjWDhTZEpi?= =?utf-8?B?czRGWU0xSy9JbUd5cmJEam4vTXFQQzU4Rk02T2RuL1ZZSmt5VWNBSlNVbFB1?= =?utf-8?B?VVhiQTZHSHczY0VCeVRlbXBvM0hnNnNnY3NyZW91dlR6RXd6VENyVzFuRnlK?= =?utf-8?B?NDVobGU0SUxLZ0VBT21FNDh1aG5LZXBLNXRuTHk1clVESWRWQmt2a0E4bWhT?= =?utf-8?B?QkJ6MFYyV1JzeDZYVnoySUp5c2hGUU5TNDNQSG9BeWpkRXdEYnRLdjZJYzY4?= =?utf-8?B?WU1hWVRIUk5ydUdnNXFoVzE0VVlUNzh0V2F5MkZlb09qelJCaFVPSVNjSXlE?= =?utf-8?B?RE1EcTUveGQ2NWV2K0ZkWE1QQWxXVTlHZElZd2tpU3A4VGVrMXY3TEErTU5N?= =?utf-8?B?Z1drQlkxR2tDOFRvQm55SFl1UDFia3hwemI2T21lZERHUEpFcWRxUm9TM0Z1?= =?utf-8?B?WmlpdCsxNTA0UXhOUEs1UkpiT0Ewc000SXE2bUo0RGdORnNQVEk2TysvTHcx?= =?utf-8?B?U1RnVWNKR2pmQ2RlaFlSSFc3UkQxUUJJcWRWVXVTYXF6ZzlzUG9CY2liU0lh?= =?utf-8?B?SDNZeVRaVXRwT01FNEg5UTZzMXdvOUlFR0NWOWVLdlBIV2Z0SEp3QVRCaTFZ?= =?utf-8?B?Y0hlYkszWnRqR0FTUUt5dlVZT2JHZ05tTGUvTUx5cHpmeUMrY1ZFSlRLVjdQ?= =?utf-8?B?QTlSUjR0SUs4WEZUSmZnZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGtFRHZQcmFqZkpoRnpKeEZCRnNjdThDSlNqTWZYK3ZUeU0vVkZGL284YVBs?= =?utf-8?B?NUM1S281MWpwTFVVaENuVE5Rd2ZQeUxFTitDS0RCaGw0b2ZJYVJUeS9NbEFo?= =?utf-8?B?N01GMVdoQ1htWmhkQmQwZ1Qza3VrbnN5NE5XRDdicjFaZHpmZ2htSDkwVU9z?= =?utf-8?B?VXRUL2FvbGowU3pMc2MrRzRjeXJac0t0VFJ4cklDOGRWVUxTNmRZTVJaTmZW?= =?utf-8?B?cHE0T3h6bzdENGo3aTg4OElGem1RTXRmYkgrdlhmOUd1MytjcWZ0STI1SWc1?= =?utf-8?B?cXJCSk9kR3ByOUZMWUc2UjhKRE9MU0RZSzVvTTcyVjc4ZHJBT3lhOWVkWE1I?= =?utf-8?B?WnZUbGdYNWgrY3Z2clVZcTV0SU10elpYK0E3WWd3aHRLald2ajk2OVFiTGk0?= =?utf-8?B?dXNPNENpMTVCVmswcFZLeHRBZ3kwSlY1ckVOeE5lMTZGSWdXczhmZENNL3R4?= =?utf-8?B?eWFaclZUOExOKzZEYmRrb3BlQmV3UldKbXU4UG1WOGQ1ajN4VzdJQ3c0VzFa?= =?utf-8?B?MDgwSjVqZ0h6blhCZlhDNGRXZldBazh5QjR2TnRrSFBGMk5maVZSRXZzWncw?= =?utf-8?B?WGtVM2YrbmkwQ3hSV0VhbDR3ckxDY2JRUE1Bb0tJVjE0QXVjYUdiQkRxSldw?= =?utf-8?B?TlpaTjVpZTJHOVMzdXVyN1UzRDVKT1lLdjRvL3VhZm5PMnRqeDUxS0M3Q0Jw?= =?utf-8?B?emIrU0dkM2lnOWNpbW5VNlV4Rmg4WjFJdktIRVBxRitlaTd4N21WWmRLeXRU?= =?utf-8?B?YVhoVm9mb0h5WXNMMklDYW8yL0M5ZXQ2ZUFvRjBDQU5LRzNEN0FwTHlBdkFJ?= =?utf-8?B?NUg1S1BLNkpaZExFTHNJdmFIenRkZTlBWTkrMHZUak9sZHE2ZElNaGM5Rm52?= =?utf-8?B?d1JiejdaRmc3ODUramhZdGdBRituSTR3L1Q0NWhnYnpoZWJxUjcvdk9WTXpl?= =?utf-8?B?c1hDWm5lQWlWWXVLcVRkakVwanJIRVNnZHIwSEpXbnk2QjFkV29ZYzU3Yk5U?= =?utf-8?B?aVhFaUtJSEU0VE8zR2trb2ttcTI3aC8wakhMaUVlNkVsV3VBUjV0dTZqMkZt?= =?utf-8?B?aWZPTGdjWi9KdjJoQlZJKzNRVnJKZzJCZGpMV1Z6dTVjZlFsM3dKejl1aE8v?= =?utf-8?B?ejltVjRQb3N4cGVvTmhIZC9MS1ZDRWkwZU51MFdLNnUyKzVHKzR3TStJZE9O?= =?utf-8?B?ZC9VT3pibFBhMTdTNms5R0FPTmtpdjY0TGZUeXYzOVBML25SOExuZ1dBUFlU?= =?utf-8?B?cjV5TXR5WlpIanJnLzhqZmtDd3NLVlhNS3Z0YXg5R3NjeVA0M2RRMmk4VkNx?= =?utf-8?B?TnhkTWFFZ29EcVl4V21qVDg4N0dzR2Fmcmp0cDZGcGcrajBLVmNRQTI0MTUz?= =?utf-8?B?RGtQZk5FTG1GTVpqMW5VWWtIUTQwellwZnY4ckNJVHF3NUI2eEFaUm5kMzI3?= =?utf-8?B?OFNCOGVCM3RHalhwaDJmTllUcWJRaFJXcitHaURlV1c3R2JGSjYyTm9xNTZh?= =?utf-8?B?aFRYVmVNQmRLMExhcTZldnlKbTZQcFd6UnN5SHJXK1lEa2Nvc3F2d1llZ3ZY?= =?utf-8?B?em9SRjV2amlYbGdkUDZvaVBoSFVZYS9BQkplSXlmSlNzQW85Si9NOGRNb285?= =?utf-8?B?Z09sOGI5VjBITytQSVNmQUxVb0JIK2taTm9KRlBuOTJXbnpGa3liNzF3SklY?= =?utf-8?B?c2ozUndtaFBqWHRXb0hrSDRFUkgzaytkdzBQb2ZoS1EvWi9IZmhjTCtXYnlB?= =?utf-8?B?V2oxL2lwM3VlTDB6WVJ4dklrRStmTEVjSWRsZER6cVVMdDJnQWtWMlNCSHRz?= =?utf-8?B?SmNNSWp4ZDhxUS9DZDNuSGhKR1oyVGJrOXNiSW1ZZVhnUkhBV3VpZ0lDbmxj?= =?utf-8?B?eVNzeWxJVnc0eG40cHh4TGZBNHJuS0tYKzRLbHV2aXlFN2tSR3Rpd2d4cTZo?= =?utf-8?B?ejdTN1M0VnRRYjMwMXhBbHpNVEx5R3luS3VPdm5SaHNSa2Z4SGZlTnR6RGVM?= =?utf-8?B?OUtHZS9ZZHlnVDd0dkh2WC9ERWRyKzFqS2pEYjM0OFVIZlN2ZVBiK09QVTkw?= =?utf-8?B?UGxpcVpCSlgwZ3JFUmtkYlVlV3RFMXhZY056SFVpMUpmU0VobHg2S09QWXFK?= =?utf-8?Q?EjNLusSc2f21Buqj4Yk4iEF1g?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: addb07ac-b0b1-4817-4b7c-08dcb6f6f30c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2024 15:38:13.7712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HlOkJBUDWhu5drjpFnkN+P1An2BPUVn7aocdmZYLIN1XlZkqFernFN1sTfcrWiEB X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7344 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > Add BMI statistics and improving the existing extended > statistics > > Signed-off-by: Hemant Agrawal > Signed-off-by: Gagandeep Singh > --- > drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++++++++++++++++++++++++++- > drivers/bus/dpaa/include/fman.h | 4 +- > drivers/bus/dpaa/include/fsl_fman.h | 12 +++++ > drivers/bus/dpaa/version.map | 4 ++ > drivers/net/dpaa/dpaa_ethdev.c | 46 +++++++++++++++++--- > drivers/net/dpaa/dpaa_ethdev.h | 12 +++++ > 6 files changed, 134 insertions(+), 9 deletions(-) > > diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c > index 24a99f7235..27b39a4975 100644 > --- a/drivers/bus/dpaa/base/fman/fman_hw.c > +++ b/drivers/bus/dpaa/base/fman/fman_hw.c > @@ -244,8 +244,8 @@ fman_if_stats_get_all(struct fman_if *p, uint64_t *value, int n) > uint64_t base_offset = offsetof(struct memac_regs, reoct_l); > > for (i = 0; i < n; i++) > - value[i] = (((u64)in_be32((char *)regs + base_offset + 8 * i) | > - (u64)in_be32((char *)regs + base_offset + > + value[i] = ((u64)in_be32((char *)regs + base_offset + 8 * i) | > + ((u64)in_be32((char *)regs + base_offset + > 8 * i + 4)) << 32); > Above change looks like a bug fix, it is converting from "(a | b) << 32" to "a | (b << 32)" Syntax wise a small change that is easy to miss, but impacts the result. Why not simplify it something like: uint64_t a = in_be32((char *)regs + base_offset + 8 * i) uint64_t b = in_be32((char *)regs + base_offset + 8 * i + 4) value[i] = a | b << 32 Anyway, my point is, should it go to its own patch, with fixes tag and stable tag, so it can be backported to stable releases. <...>