From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78DD942306; Mon, 20 Mar 2023 00:29:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B2A840A7F; Mon, 20 Mar 2023 00:29:03 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 4ABB7406BC for ; Mon, 20 Mar 2023 00:29:01 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2B4FA5C00D2; Sun, 19 Mar 2023 19:29:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 19 Mar 2023 19:29:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679268540; x=1679354940; bh=CnRjGzFV/qaJu/JzYPQFtyjvX1L0wwFiB9I ZYO1T0bA=; b=GSqtOuJi7l1tA/7ukjI4g47s6pG4nFfy8vbRgiNenYBgFopoL6i D9Kb2S+EPosK5y48XHj399Prl5UeuLBfjIS5hqHV7a6QOgqlIAsfA603tImL3PXl wEAyztt5cLI5GEbfQixd+OQ2JV2B4+COChRM/mrB6bgpm7BSby35qkDjYckuXOMH 5PFHJNnzghQ3BKDIgV57XEu5r0uc8pJhNhp91TNKYKK9OUoFqMZStaO+K1Tp5eua bw8ZCyUnxxCzemyBnRmnyr2W5cRhT+LxjALXNzwQ7lZHttJohehjQLBnVQRdq0XZ 0bbVbXPoMO7y1HKm8X8p83qEgevLUxdOzog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679268540; x=1679354940; bh=CnRjGzFV/qaJu/JzYPQFtyjvX1L0wwFiB9I ZYO1T0bA=; b=qeNzwrTzQhtonxxjR5/gj5PhZ3uBVabjc9yTh1q1cz8LrH4vBAG sYD9LIuA4XQWMfHOQ68V4GOQ4Ef+mlq9eUt1WrbT0soTWn2objWznxSUz04xmAD7 aYHQopi34aJvuKvj7bl3VkfGbXfpyGg6+DOL8idSvIOuj579bL6P2z6qiaGvXMg0 q0xx58Hl//flqrk3ienBuzFW65ZiC7YgymhpoNQjOFLzgTPYWaADQ4dxfo7o6oSb KDqorShd3hpdKVs0adUGqXhUrxhiWf+UErI6hvABq8YRP1JgBnEiUitlhJsjBg3M jKVpfb6ssC9wcWJCuaJI832CeHqEvkKWtEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefjedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Mar 2023 19:28:59 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit , Olivier Matz Subject: Re: [PATCH v5] testpmd: go back to using cmdline_interact Date: Mon, 20 Mar 2023 00:28:57 +0100 Message-ID: <1793747.8hzESeGDPO@thomas> In-Reply-To: References: <20230313171905.67720-1-stephen@networkplumber.org> <20230317165941.62619-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/03/2023 22:12, Olivier Matz: > On Fri, Mar 17, 2023 at 09:59:41AM -0700, Stephen Hemminger wrote: > > The cmdline_poll() function is broken and was > > not fully tested, don't use it. > > > > Instead, use sigaction() to cancel read character on Unix OS's > > and a new helper to cancel I/O on Windows. > > > > Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") > > Bugzilla ID: 1180 > > Signed-off-by: Stephen Hemminger > > Acked-by: Olivier Matz > > Thank you Applied, thanks. I hope we won't have new issues with testpmd in -rc3.