From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id C648A594C
 for <dev@dpdk.org>; Thu, 17 Apr 2014 15:40:17 +0200 (CEST)
Received: by mail-wg0-f46.google.com with SMTP id b13so449129wgh.17
 for <dev@dpdk.org>; Thu, 17 Apr 2014 06:40:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=BryXK0RLI9mBOmXtSDKW07z7DFyaScxCzLUIt+K6J0Q=;
 b=Z8Pj2LoNSZ8ndxgBhafb2ecJEDVFealSb54uBQy1tFKpVpKZnvTRGyws8YLglNZfDo
 bnsJ5ujD6OA4PCRPV+jH3yafuYskd7dREPgIKhcoNvI8/w7b+coShyQ6Q1N0q96untKh
 +DeKVfig4y7fqJBI7MyGti1AQTCRKR51IVWgbBa7jmvKD8WwvI1xK7eo9VFlVJFZPao9
 oV2ybezHXsHEfYtPBWOfeNnpmnSM1ew8ekbNyErULvl3GtAzRrOvAUHxTGwjiQHQirM4
 ETQ/V2fqOZ2vTQ+L0ONTKFjNsmdX2VNYLnH+xLnX70Ond7XVsSIGw/+Poqg2yxfDNJ2d
 li/Q==
X-Gm-Message-State: ALoCoQnGrnSixYrnQ9qIRVWMiBTwViR1vkC7JTA7ZFRL73piGU1Y+dX/8cJi89od+C6Mc5WwRwKh
X-Received: by 10.180.85.134 with SMTP id h6mr24287020wiz.44.1397742018233;
 Thu, 17 Apr 2014 06:40:18 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id i9sm4935563wiy.17.2014.04.17.06.40.16
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 17 Apr 2014 06:40:17 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 17 Apr 2014 15:40:17 +0200
Message-ID: <1794311.7dRdTpIyDP@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; )
In-Reply-To: <2143975.C98iGihseR@xps13>
References: <20140227091856.768d413c@nehalam.linuxnetplumber.net>
 <2143975.C98iGihseR@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Apr 2014 13:40:18 -0000

Hi Stephen,
This patch is still pending.
Please send a v2.

2014-03-20 17:30, Thomas Monjalon:
> Hi,
>=20
> I have some minor comments below.
>=20
> 27/02/2014 09:18, Stephen Hemminger :
> > The function rte_snprintf() can never be inlined by Gcc.
> >=20
> > If compiled with -Winline it generates an error:
> >  function =E2=80=98rte_snprintf=E2=80=99 can never be inlined becau=
se it uses variable
> >=20
> > argument lists [-Werror=3Dinline]
> >=20
> > Therefore since both rte_snprintf and rte_strsplit are not performa=
nce
> > sensitive just move them to being real functions.
> >=20
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >=20
> > --- /dev/null
> > +++ b/lib/librte_eal/common/eal_common_string_fns.c
> > @@ -0,0 +1,95 @@
> > +/*-
> > + *   BSD LICENSE
> > + *
> > + *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved=
.
>=20
> It is now 2014 in version 1.6.0.
>=20
> [...]
>=20
> > +#include <stdio.h>
> > +#include <stdarg.h>
> > +#include <stddef.h>
> > +#include <errno.h>
>=20
> I think stddef.h is not needed.
>=20
> [...]
>=20
> > --- a/lib/librte_eal/common/include/rte_string_fns.h
> > +++ b/lib/librte_eal/common/include/rte_string_fns.h
> > @@ -47,7 +47,6 @@ extern "C" {
> >=20
> >  #include <stdio.h>
> >  #include <stdarg.h>
> >  #include <stddef.h>
> >=20
> > -#include <errno.h>
>=20
> stdarg and stddef are not needed.
>=20
> [...]
>=20
> > +int
> > +rte_snprintf(char *buffer, int buflen, const char *format, ...);
>=20
> One blank line should be sufficient.
>=20
> > +int
> >=20
> >  rte_strsplit(char *string, int stringlen,
>=20
> Thank you